Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/packages: tests spam stderr #30994

Closed
bradfitz opened this issue Mar 21, 2019 · 3 comments
Closed

x/tools/go/packages: tests spam stderr #30994

bradfitz opened this issue Mar 21, 2019 · 3 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@bradfitz
Copy link
Contributor

The x/tools/go/packages test spam stderr:

bradfitz@go:~/src/golang.org/x/tools/go/packages$ go test -short
{"ImportPath": "","Incomplete": true,"Error": {"Pos": "","Err": "named files must be .go files"}}
PASS
ok      golang.org/x/tools/go/packages  8.202s
@bradfitz bradfitz added Testing An issue that has been verified to require only test changes, not just a test failure. help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Mar 21, 2019
@bradfitz bradfitz added this to the Go1.13 milestone Mar 21, 2019
@matloob
Copy link
Contributor

matloob commented Mar 22, 2019

Was this fixed in a recent change? I can't reproduce at head...

matloob-macbookpro2:tools matloob$ go test -short golang.org/x/tools/go/packages
ok  	golang.org/x/tools/go/packages	15.964s

@bradfitz
Copy link
Contributor Author

It still repros for me on Linux at tip:

bradfitz@go:~/src/golang.org/x/tools/go/packages$ go version
go version devel +d923309a17 Fri Mar 22 17:26:03 2019 +0000 linux/amd64

bradfitz@go:~/src/golang.org/x/tools/go/packages$ go test -short
{"ImportPath": "","Incomplete": true,"Error": {"Pos": "","Err": "named files must be .go files"}}
ok      golang.org/x/tools/go/packages  9.284s

bradfitz@go:~/src/golang.org/x/tools/go/packages$ git rev-parse HEAD
e779aa49e359eb9a328069406fafdb0d559c205d

@gopherbot
Copy link

Change https://golang.org/cl/168939 mentions this issue: go/packages: remove spurious print

@golang golang locked and limited conversation to collaborators Mar 21, 2020
@rsc rsc unassigned matloob Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

3 participants