Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: bugs in "Using Go Modules" #30954

Closed
skybrian opened this issue Mar 20, 2019 · 2 comments
Closed

blog: bugs in "Using Go Modules" #30954

skybrian opened this issue Mar 20, 2019 · 2 comments

Comments

@skybrian
Copy link
Contributor

https://blog.golang.org/using-go-modules

  • There's a duplicate section starting with: "Note that our module now depends on both rsc.io/quote and rsc.io/quote/v3:"

  • In the example of upgrading a major version, Hello was renamed to HelloV3, but the name in the calling code isn't fixed. It should be "quoteV3.HelloV3", not "quoteV3.Hello".

@gopherbot
Copy link

Change https://golang.org/cl/168403 mentions this issue: blog: update using-go-modules.article

@andybons
Copy link
Member

@skybrian Thanks, Brian!

cwarden referenced this issue in golang/blog Mar 20, 2019
Change-Id: I94f26a6e33e19e34ea50de036c167649ee8d0e67
Reviewed-on: https://go-review.googlesource.com/c/blog/+/168357
Reviewed-by: Steve Francia <spf@golang.org>
@golang golang locked and limited conversation to collaborators Mar 19, 2020
gopherbot pushed a commit to golang/website that referenced this issue May 26, 2021
Fixes golang/go#30954

Change-Id: I6aec3d3e54bdcaa12c4e853abe934529e273900b
Reviewed-on: https://go-review.googlesource.com/c/blog/+/168403
Reviewed-by: Jay Conrod <jayconrod@google.com>
X-Blog-Commit: fad1b87c54a720b166bbf46d5c5d47ca9aecad47
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
Fixes golang/go#30954

Change-Id: I6aec3d3e54bdcaa12c4e853abe934529e273900b
Reviewed-on: https://go-review.googlesource.com/c/blog/+/168403
Reviewed-by: Jay Conrod <jayconrod@google.com>
X-Blog-Commit: fad1b87c54a720b166bbf46d5c5d47ca9aecad47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants