You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'd like CL 168200 to be cherry-picked for 1.12.2.
This was the second fix for #30374 (its first backport issue was #30684). The first fix, CL 164877, was backported and released in 1.12.1, but it missed an important case that was discovered later.
#30374 (aka #30684) was a regression from GOPATH mode, and the fix is again straightforward.
(I know gopherbot usually opens these issues; I asked politely, but it didn't do it).
The text was updated successfully, but these errors were encountered:
…s main packages (more)
This fixes two problems missed in CL 164877.
First, p.Internal.BuildInfo is now part of the cache key. This is
important since p.Internal.BuildInfo causes the build action to
synthesize a new source file, which affects the output.
Second, recompileForTest is always called for test
packages. Previously, it was only called when there were internal test
sources, so the fix in CL 164877 did not apply to packages that only
had external tests.
Fixes#30937
Change-Id: Iac2d7e8914f0313f9ab4222299a866f67889eb2e
Reviewed-on: https://go-review.googlesource.com/c/go/+/168200
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit d34548e)
Reviewed-on: https://go-review.googlesource.com/c/go/+/168717
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
I'd like CL 168200 to be cherry-picked for 1.12.2.
This was the second fix for #30374 (its first backport issue was #30684). The first fix, CL 164877, was backported and released in 1.12.1, but it missed an important case that was discovered later.
#30374 (aka #30684) was a regression from GOPATH mode, and the fix is again straightforward.
(I know gopherbot usually opens these issues; I asked politely, but it didn't do it).
The text was updated successfully, but these errors were encountered: