Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go 1.12 binaries rejected from mac app store due to ___getdirentries64 #30933

Closed
zx2c4 opened this issue Mar 19, 2019 · 17 comments
Closed

go 1.12 binaries rejected from mac app store due to ___getdirentries64 #30933

zx2c4 opened this issue Mar 19, 2019 · 17 comments
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Darwin
Milestone
Go1.13

Comments

@zx2c4
Copy link
Contributor

zx2c4 commented Mar 19, 2019 •
edited

The release notes mention something clever with regards to iOS, but not with regards to macOS. Here's a rejection I just received from Apple:

Guideline 2.5.1 - Performance - Software Requirements

Your app uses or references the following non-public APIs:

Symbol: ___getdirentries64
From framework: /usr/lib/libSystem.B.dylib
In binary: Contents/PlugIns/WireGuardNetworkExtension.appex/Contents/MacOS/WireGuardNetworkExtension

The use of non-public APIs is not permitted on the App Store, because it can lead to a poor user experience should these APIs change.

We are constantly reevaluating and identifying non-public APIs that you may have been using for an extended period of time. You should always use public APIs and frameworks and ensure they are up-to-date to prevent this issue in the future.

It then goes on with the usual boiler plate.

Note that this is for the macOS app store.

As I'm not using getdirentries64 (at least, I don't think I am...), I'll probably patch the runtime in some grotesque and heavy-handed way to make the problem go away in the short term. But Go really needs a proper solution to this. I imagine they're something like one of these:

  • Find a different syscall that isn't getdirentries, or
  • When being built for the app store, make the actual syscall instead of going through libsystem, or
  • Load the symbol with dlsym lazily as needed, rather than declaring it in the ELF, so that only users who use this get flagged, or
  • Remove this from go all together.
@zx2c4
Copy link
Contributor Author

zx2c4 commented Mar 19, 2019

These are somewhat grotesque, but I just resubmitted using these:

https://git.zx2c4.com/wireguard-ios/tree/wireguard-go-bridge/goruntime-syscall-remove-getdirentries.diff
https://git.zx2c4.com/wireguard-ios/tree/wireguard-go-bridge/sys-unix-remove-getdirentries.diff

@zx2c4
Copy link
Contributor Author

zx2c4 commented Mar 19, 2019

This appears to be an unforeseen extension of #28984 . CC @eliasnaur

@eliasnaur
Copy link
Contributor

It seems that my fix for iOS needs to cover all of Darwin. I don't have the bandwidth right now, so I'm hoping someone else will take this up. Perhaps @randall77 can take a look.

@zx2c4
Copy link
Contributor Author

zx2c4 commented Mar 19, 2019

Was your iOS fix something beyond just ENOSYS'ing those syscalls? If so, those two patches I linked above basically do that, and I can submit them to gerrit. Or did you actually wind up wrapping libc's readdir as a replacement?

@eliasnaur
Copy link
Contributor

Yes, I had to replace getdirentries in the directory listing code in the runtime. See https://go-review.googlesource.com/c/go/+/153338/. There was also an issue with the "64" suffixed system calls, but that might be different for macOS.

@bradfitz bradfitz added OS-Darwin NeedsFix The path to resolution is known, but the work has not been done. labels Mar 19, 2019
@bradfitz bradfitz added this to the Go1.13 milestone Mar 19, 2019
@bradfitz bradfitz added the CherryPickCandidate Used during the release process for point releases label Mar 19, 2019
@randall77
Copy link
Contributor

I think we'll need to do the same thing as CL 153338 for macOS.

@zx2c4
Copy link
Contributor Author

zx2c4 commented Mar 20, 2019

Thanks for making it as cherrypickcandidate. I assume that means it'll wind up in 1.12.2, as this is sort of a significant regression.

@gopherbot
Copy link

Change https://golang.org/cl/168479 mentions this issue: syscall: deprecate Getdirentries on darwin

@randall77
Copy link
Contributor

@zx2c4, if you could patch the above CL in and try it, that would help.

@zx2c4
Copy link
Contributor Author

zx2c4 commented Mar 20, 2019

I'll give it a go and report back. Note that you'll also need a corresponding one in x/sys, because that also links to the symbol.

@randall77
Copy link
Contributor

@zx2c4: right.

@andybons
Copy link
Member

andybons commented Apr 2, 2019

@zx2c4 any word on trying the patch?

@zx2c4
Copy link
Contributor Author

zx2c4 commented Apr 2, 2019

The CL still has crashes, last I read. Meanwhile I'm just ENOSYSing it out, which is suitable for my purposes.

@randall77
Copy link
Contributor

@gopherbot please consider this for backport to 1.12.

@gopherbot gopherbot mentioned this issue Apr 3, 2019
Closed
@gopherbot
Copy link

Backport issue(s) opened: #31244 (for 1.12).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

@mikepulaski
Copy link

Thanks @randall77! I've just received a rejection from the Mac App Store for this very issue. I'll use version 1.11 until this makes it into an official release.

@eliasnaur eliasnaur mentioned this issue Apr 12, 2019
Closed
@halseth halseth mentioned this issue May 2, 2019
Closed
@constantinevassil
Copy link

constantinevassil commented May 15, 2019 •
edited

If you submitted to AppStore for review was it with BITCODE = YES?

I cannot use gomobile bind -target=ios ... in a way when the framework is imported
in Xcode to compile with BITCODE = YES

How we solve this issue?

@zx2c4 zx2c4 mentioned this issue Sep 19, 2019
Closed
@golang golang locked and limited conversation to collaborators May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Darwin
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
8 participants
@bradfitz @zx2c4 @mikepulaski @andybons @eliasnaur @randall77 @gopherbot @constantinevassil