-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: dist.exe can't find mercurial (hg) on Windows if VERSION file is missing #3093
Labels
Comments
Russ, I can reproduce this. I think the problem is that we use CreateProcess windows API with lpApplicationName == nil and lpCommandLine == "hg ...". This combination invokes this rule: "... the first white space–delimited token of the command line specifies the module name. ... If the file name does not contain an extension, .exe is appended. Therefore, if the file name extension is .com, this parameter must include the .com extension. ..." (http://goo.gl/m24Rh). So, it is not even trying to look for hg.bat. We can add another call to CreateProcess("hg.bat") if CreateProcess("hg") fails. But I am reluctant to deal with batch files altogether. Given our experience with all.bat, how are we going to know if hg runs to successful completion? Alex Labels changed: added os-windows. Owner changed to @alexbrainman. Status changed to Thinking. |
This issue was closed by revision 0669261. Status changed to Fixed. |
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
by Jasonryanphillips:
The text was updated successfully, but these errors were encountered: