-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/internal/lsp: add support for document symbols #30915
Comments
I'm looking into this and figured I'd log an issue for visibility. |
Change https://golang.org/cl/168338 mentions this issue: |
Updates golang/go#30915 Change-Id: I9a447f7748eb9894fb6f4072febec132b2ed91d7 Reviewed-on: https://go-review.googlesource.com/c/tools/+/168338 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
Change https://golang.org/cl/169438 mentions this issue: |
Remaining tasks:
|
This change uses go/types information to get the types for the different symbols. It also groups the symbols according to their kinds, though this doesn't seem to be reflected in the actual VSCode UI... Updates golang/go#30915 Change-Id: I2caefe01f9834aaad6b9e81cd391d461405ef725 Reviewed-on: https://go-review.googlesource.com/c/tools/+/169438 Reviewed-by: Ian Cottrell <iancottrell@google.com>
Change https://golang.org/cl/169682 mentions this issue: |
Updates golang/go#30915 Change-Id: I9c5faa615df506cf1d015a9eb48196fa9b0387ee Reviewed-on: https://go-review.googlesource.com/c/tools/+/169682 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Change https://golang.org/cl/170198 mentions this issue: |
Make methods children of their receiver's type symbol. Add struct fields as children of the struct's type symbol. Also identify numeric, boolean, and string types. Updates golang/go#30915 Fixes golang/go#31202 Change-Id: I33c4ea7b953e981ea1e858505b77c7a3ba6ee399 Reviewed-on: https://go-review.googlesource.com/c/tools/+/170198 Run-TryBot: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
I think at this point we can count this issue as fixed. We can file issues for further improvements separately. Thanks for contributing, @zmb3! |
Tracking issue to add support for the document symbols request
The text was updated successfully, but these errors were encountered: