Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/lsp: add support for document symbols #30915

Closed
zmb3 opened this issue Mar 18, 2019 · 7 comments
Closed

x/tools/internal/lsp: add support for document symbols #30915

zmb3 opened this issue Mar 18, 2019 · 7 comments
Labels
Documentation FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@zmb3
Copy link
Contributor

zmb3 commented Mar 18, 2019

Tracking issue to add support for the document symbols request
@gopherbot gopherbot added this to the Unreleased milestone Mar 18, 2019
@zmb3
Copy link
Contributor Author

zmb3 commented Mar 18, 2019

I'm looking into this and figured I'd log an issue for visibility.

@stamblerre stamblerre added the gopls Issues related to the Go language server, gopls. label Mar 19, 2019
@gopherbot
Copy link

Change https://golang.org/cl/168338 mentions this issue: x/tools/internal/lsp: add support for document symbols

gopherbot pushed a commit to golang/tools that referenced this issue Mar 25, 2019
@zmb3 @stamblerre
x/tools/internal/lsp: add support for document symbols
1d95b17 
Updates golang/go#30915

Change-Id: I9a447f7748eb9894fb6f4072febec132b2ed91d7
Reviewed-on: https://go-review.googlesource.com/c/tools/+/168338
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/169438 mentions this issue: internal/lsp: group document symbols and add more detail

@stamblerre
Copy link
Contributor

Remaining tasks:

  • Add struct fields as children of the struct document symbol.
  • Associate struct methods with the struct document symbol.
  • List methods as children of an interface symbol (maybe?)

gopherbot pushed a commit to golang/tools that referenced this issue Mar 26, 2019
@stamblerre
internal/lsp: group document symbols and add more detail
c02eab1 
This change uses go/types information to get the types for the
different symbols. It also groups the symbols according to their kinds,
though this doesn't seem to be reflected in the actual VSCode UI...

Updates golang/go#30915

Change-Id: I2caefe01f9834aaad6b9e81cd391d461405ef725
Reviewed-on: https://go-review.googlesource.com/c/tools/+/169438
Reviewed-by: Ian Cottrell <iancottrell@google.com>
@gopherbot
Copy link

Change https://golang.org/cl/169682 mentions this issue: internal/lsp: correctly report interface symbols

gopherbot pushed a commit to golang/tools that referenced this issue Mar 28, 2019
@zmb3 @stamblerre
internal/lsp: correctly report interface symbols
8f05a32 
Updates golang/go#30915

Change-Id: I9c5faa615df506cf1d015a9eb48196fa9b0387ee
Reviewed-on: https://go-review.googlesource.com/c/tools/+/169682
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/170198 mentions this issue: internal/lsp: make method symbols children of types

gopherbot pushed a commit to golang/tools that referenced this issue Apr 10, 2019
@zmb3 @stamblerre
internal/lsp: enhance document symbols support
2538eef 
Make methods children of their receiver's type symbol.
Add struct fields as children of the struct's type symbol.
Also identify numeric, boolean, and string types.

Updates golang/go#30915
Fixes golang/go#31202

Change-Id: I33c4ea7b953e981ea1e858505b77c7a3ba6ee399
Reviewed-on: https://go-review.googlesource.com/c/tools/+/170198
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 12, 2019
@stamblerre
Copy link
Contributor

I think at this point we can count this issue as fixed. We can file issues for further improvements separately. Thanks for contributing, @zmb3!

@golang golang locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bcmills @stamblerre @zmb3 @gopherbot