Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: internal/ssa TestNexting failing #30912

Closed
katiehockman opened this issue Mar 18, 2019 · 7 comments
Closed

cmd/compile: internal/ssa TestNexting failing #30912

katiehockman opened this issue Mar 18, 2019 · 7 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.13

Comments

@katiehockman
Copy link
Contributor

katiehockman commented Mar 18, 2019 •
edited

Change d949d0b (cmd/compile: reorganize init functions) seems to have failed the TestNexting test in the cmd/compile/internal/ssa package for linux-amd64-longtest builds

--- FAIL: TestNexting (10.74s)
    --- FAIL: TestNexting/gdb-dbg-i22558 (0.48s)
        debug_test.go:241: step/next histories differ, diff=
            --- testdata/i22558.gdb-dbg.nexts	2019-03-18 21:16:19.000000000 +0000
            +++ /workdir/tmp/debug_test137844848/test-i22558.gdb-dbg.nexts	2019-03-18 21:42:04.493540912 +0000
            @@ -2,3 +2,10 @@
             19:	func test(t *thing, u *thing) {
             20:		if t.next != nil {
             23:		fmt.Fprintf(os.Stderr, "%s\n", t.name)
            +24:		u.self = u
            +25:		t.self = t
            +26:		t.next = u
            +27:		for _, p := range t.stuff {
            +28:			if isFoo(t, p) {
            +29:				return
            +44:	}
FAIL
FAIL	cmd/compile/internal/ssa	85.797s

https://build.golang.org/log/cb49293c3202a9d78ae2324b5a8217e99dc82e8a

cc @randall77
@katiehockman katiehockman changed the title cmd/compile: internal/ssa TestNexting flaky cmd/compile: internal/ssa TestNexting failing Mar 18, 2019
@randall77
Copy link
Contributor

@dr2chase

@katiehockman
Copy link
Contributor Author

This seems to be failing x/tools builds as well:
https://build.golang.org/log/f1e3906e966da6b4c3a47af7cf1b005e95f2c906

@dr2chase
Copy link
Contributor

I'll give it a look tomorrow, but superficially it looks like the behavior got better.

@ALTree ALTree added the Testing An issue that has been verified to require only test changes, not just a test failure. label Mar 19, 2019
@ALTree ALTree added this to the Go1.13 milestone Mar 19, 2019
@ALTree ALTree added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 19, 2019
@gopherbot
Copy link

Change https://golang.org/cl/168377 mentions this issue: cmd/compile: fix ssa/debug_test.go reference file

@katiehockman
Copy link
Contributor Author

@dr2chase will you also be making the fix to the test that failed [ExampleRead] in x/tools as well, or would you like help with that? The fix seems straightforward enough that I can likely do it if needed.

@katiehockman katiehockman reopened this Mar 19, 2019
@katiehockman
Copy link
Contributor Author

Re-opening this just to track the other related x/tools bug. Can keep track in a separate issue if that's easier.

@gopherbot
Copy link

Change https://golang.org/cl/168397 mentions this issue: tools/go: fix gcexportdata example to match new compiler behavior

@golang golang locked and limited conversation to collaborators Mar 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
5 participants
@dr2chase @ALTree @randall77 @gopherbot @katiehockman