New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/http: Detect MIME type of v5 RAR archives #30909
Conversation
This PR (HEAD: b662561) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/168039 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/168039. |
Message from Brad Fitzpatrick: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/168039. |
Message from Janis Petersons: Patch Set 1:
The specification is likely outdated in this regard. There is little sense in including the older RAR v1.5-v4.0 signature but excluding the newer v5+ signature. Some archiving tools already default to the newer format. Not adding this can create unexpected behavior of some RAR files matching and others not, unless the user of net/http is explicitly aware of there being a newer unsupported format in circulation. Please don’t reply on this GitHub thread. Visit golang.org/cl/168039. |
Message from Brad Fitzpatrick: Patch Set 1: Run-TryBot+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/168039. |
Message from Gobot Gobot: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=a313c179 Please don’t reply on this GitHub thread. Visit golang.org/cl/168039. |
Message from Gobot Gobot: Patch Set 1: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/168039. |
This PR is being closed because golang.org/cl/168039 has been merged. |
Change-Id: Id9dedc861523e2dafe0e67f70862973124fa07b3 GitHub-Last-Rev: b662561 GitHub-Pull-Request: #30909 Reviewed-on: https://go-review.googlesource.com/c/go/+/168039 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
No description provided.