Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: Detect MIME type of v5 RAR archives #30909

Closed
wants to merge 1 commit into from
Closed

net/http: Detect MIME type of v5 RAR archives #30909

wants to merge 1 commit into from

Conversation

bakape
Copy link
Contributor

@bakape bakape commented Mar 18, 2019

No description provided.

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Mar 18, 2019
@gopherbot
Copy link

This PR (HEAD: b662561) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/168039 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/168039.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/168039.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Janis Petersons:

Patch Set 1:

Patch Set 1:

(1 comment)

The specification is likely outdated in this regard. There is little sense in including the older RAR v1.5-v4.0 signature but excluding the newer v5+ signature. Some archiving tools already default to the newer format. Not adding this can create unexpected behavior of some RAR files matching and others not, unless the user of net/http is explicitly aware of there being a newer unsupported format in circulation.


Please don’t reply on this GitHub thread. Visit golang.org/cl/168039.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 1: Run-TryBot+1 Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/168039.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=a313c179


Please don’t reply on this GitHub thread. Visit golang.org/cl/168039.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/168039.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR is being closed because golang.org/cl/168039 has been merged.

@gopherbot gopherbot closed this Mar 18, 2019
gopherbot pushed a commit that referenced this pull request Mar 18, 2019
Change-Id: Id9dedc861523e2dafe0e67f70862973124fa07b3
GitHub-Last-Rev: b662561
GitHub-Pull-Request: #30909
Reviewed-on: https://go-review.googlesource.com/c/go/+/168039
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@bakape bakape deleted the dev/sniff-rar-v5 branch March 18, 2019 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants