New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/trace: generate trace graph for custom region selection #30895
Comments
CC @ianthehat |
The actual viewer UI is part of Chrome DevTools (now Catapult) and is taken from upstream. |
Was thinking of a multi list selector in the web UI but if that's too much, I guess a command line arg would be good enough. Maybe |
How is a region defined? Can you give a specific example of the |
When I say "regions" I meant trace regions users defined by using e.g.
And then you execute |
@hyangah and @pjweinbgo, does the command line option in the comment above this one seem reasonable? Also is it implementable? Thanks. |
@AlexRouSg can you elaborate what information you want to see from the output visualization?
|
Like what you get when you go to http://127.0.0.1:49854/trace?taskid=1#0:1284.290663 but instead of seeing events for the selected task, you see events for a selected list of regions that may or may not be in the same task or have a task.
The URL for accessing the graph. I don't really care about this part. |
@hyangah and @pjweinbgo, does this seem like something that can be implemented? I'm not asking you to implement it, just to weigh in on whether it makes sense to accept as a path forward. Thanks. |
@rsc I don't think I fully understand the proposed feature even though I agree that cmd/trace needs more love. Sketch of the desired visualization, or concrete examples may be helpful. |
@AlexRouSg why not just implementing an handler in the server-side, take the region name or regexp as a text input field, and pass it to the handler? (instead of the command line flag). The visualization needs to be careful when handling the case where there are so many matching regions and tasks. |
command line requires reparsing of the trace. I think a simple text input box would be good enough. |
I'm fine with a textbox |
It sounds like there is an agreement here about a text input box for selecting the trace subsection. I will mark this as accepted but I don't think we plan to do it any time soon. Help welcome. |
I propose that cmd/trace should have an option in the web UI to generate a trace graph for an arbitrary list of user defined regions.
I want/need to see the timing between certain user defined regions and having such an option in the web ui would be very useful. I could just dump them all into the same task but this means recompiling the program and changing code just to change what regions get shown together. Also if the program failed to call
task.End()
for any reason, then the trace graph doesn't get generated at all.The text was updated successfully, but these errors were encountered: