Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: write barrier incorrect on wasm #30871

Closed
aclements opened this issue Mar 15, 2019 · 4 comments
Closed

runtime: write barrier incorrect on wasm #30871

aclements opened this issue Mar 15, 2019 · 4 comments
Labels
arch-wasm WebAssembly issues FrozenDueToAge
Milestone
Go1.13

Comments

@aclements
Copy link
Member

The implementation of the write barrier on wasm incorrectly implements the "deletion" part of the barrier, and has since the code was introduced in Go 1.11. I have a fix. This issue is to track backports.
@aclements aclements added the arch-wasm WebAssembly issues label Mar 15, 2019
@aclements aclements added this to the Go1.13 milestone Mar 15, 2019
@aclements aclements self-assigned this Mar 15, 2019
@gopherbot
Copy link

Change https://golang.org/cl/167743 mentions this issue: runtime: fix write barrier on wasm

@aclements
Copy link
Member Author

@gopherbot, please backport to Go 1.12 and Go 1.11.

@gopherbot gopherbot mentioned this issue Mar 15, 2019
Closed
@gopherbot
Copy link

Backport issue(s) opened: #30872 (for 1.11), #30873 (for 1.12).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

@gopherbot gopherbot mentioned this issue Mar 15, 2019
Closed
@aclements
Copy link
Member Author

Thanks @gopherbot!

@golang golang locked and limited conversation to collaborators Mar 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly issues FrozenDueToAge
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
2 participants
@aclements @gopherbot