-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: Dragonfly builder is failing to remove workdir #30853
Comments
That probably comes from here:
So, two questions:
|
When this happens, it goes into a loop of continually trying the remove and prevents the builder from running. This just started sometime in the past week. |
I don't know why https://golang.org/cl/156078 wouldn't take care of this. I just double-checked and on my workstation it doesn't leave directories behind, even in cases of test failure. I guess we can change Cleanup() to return an error and maybe that'll shed light on the problem? |
I can try a debug patch, if you have one. For now, I'm running the builder as root to work around this. |
This is working now (running as not root), but I didn't really do anything other than rebuild the buildlet, which hadn't been refreshed in some time. |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhen the builder tries to remove the existing /tmp workdir, this happens:
2019/03/14 20:05:58 buildlet starting.
2019/03/14 20:05:58 remove /tmp/workdir-host-dragonfly-amd64-tdfbsd/tmp/TestSimpleCases_import_grouping_not_path_dependent_no_groups_Modules_GoPackages625130825/modcache/pkg/mod/github.com/local@v1.0.0/go.mod: permission denied
^C
% ls -l /tmp/workdir-host-dragonfly-amd64-tdfbsd/tmp/TestSimpleCases_import_grouping_not_path_dependent_no_groups_Modules_GoPackages625130825/modcache/pkg/mod/github.com/local@v1.0.0/
total 16
dr-xr-xr-x 2 tim wheel 88 Mar 14 16:04 bar
-r--r--r-- 1 tim wheel 24 Mar 14 16:04 go.mod
So, the direct cause is that go.mod is being created with read-only permissions. I have no idea when this started happening though, or why.
The text was updated successfully, but these errors were encountered: