Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: TryBots for golang.org/dl subrepo place code at wrong location #30852

Closed
bcmills opened this issue Mar 14, 2019 · 3 comments
Closed

x/build: TryBots for golang.org/dl subrepo place code at wrong location #30852

bcmills opened this issue Mar 14, 2019 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Mar 14, 2019

The TryBot run for https://golang.org/cl/167703 failed, and the failure appears to be spurious.

Looking at the error message, it appears that the builder is running at $GOPATH/src/golang.org/x/dl, but the actual repo path does not have the /x component. That causes the build to fail in GOPATH mode, since internal imports cannot be resolved.

CC @dmitshur @bradfitz

linux-amd64 at aa193c0b9623acd7397c0799ffc9efe5845216b2 building dl at 1fd72ee045448e802db0932c08bf55095b3992f8

:: Running /workdir/go/bin/go with args ["/workdir/go/bin/go" "test" "-short" "golang.org/x/dl/..."] and env ["PATH=/workdir/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-jessie-rnef69983" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=0s" "GO_STAGE0_DL_DELAY=100ms" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-amd64" "GOROOT_BOOTSTRAP=/go1.4" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOROOT=/workdir/go" "GOPATH=/workdir/gopath" "GOPROXY=http://10.240.0.49:30156" "GO111MODULE=auto" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/gopath/src/golang.org/x/dl

go1.10/main.go:20:8: cannot find package "golang.org/dl/internal/version" in any of:
	/workdir/go/src/golang.org/dl/internal/version (from $GOROOT)
	/workdir/gopath/src/golang.org/dl/internal/version (from $GOPATH)


Error: tests failed: exit status 1
@gopherbot gopherbot added this to the Unreleased milestone Mar 14, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Mar 14, 2019
@bradfitz
Copy link
Contributor

Yeah, "dl" is a special case. So far all the "subrepos" (legacy hg term) became golang.org/x/$foo, but not dl.

@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Mar 14, 2019
@gopherbot
Copy link

Change https://golang.org/cl/170417 mentions this issue: cmd/coordinator: fix trybots for the "dl" repo

@dmitshur dmitshur mentioned this issue Nov 14, 2019
Closed
@gopherbot
Copy link

Change https://golang.org/cl/212023 mentions this issue: cmd/coordinator: fix trybots for the "dl" repo more

gopherbot pushed a commit to golang/build that referenced this issue Dec 20, 2019
@dmitshur
cmd/coordinator: fix trybots for the "dl" repo, part 2
17a7d87 
This continues the work started in CL 170417,
and hopefully finishes it.

Fixes golang/go#35581
Updates golang/go#30852

Change-Id: Ie666ead86dccb4de7dfc2ca94c79f4592b2da47a
Reviewed-on: https://go-review.googlesource.com/c/build/+/212023
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@golang golang locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @dmitshur @bcmills @gopherbot