Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestCloseWrite for SOCK_SEQPACKET failing on SmartOS #30840

Closed
bcmills opened this issue Mar 14, 2019 · 5 comments
Closed

net: TestCloseWrite for SOCK_SEQPACKET failing on SmartOS #30840

bcmills opened this issue Mar 14, 2019 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Solaris Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.13

Comments

@bcmills
Copy link
Contributor

bcmills commented Mar 14, 2019

Looking at the recent test flakes on solaris-amd64-smartosbuildlet, the vast majority of them are failures in TestCloseWrite.

For an example, see https://build.golang.org/log/f41d2e44b0629db5f3b5e32eec5751b465f4717f:

--- FAIL: TestCloseWrite (0.00s)
    net_test.go:153: got (0, read unixpacket ->/tmp/workdir/tmp/go-nettest264897916: not pollable); want (0, io.EOF)
FAIL
FAIL	net	9.459s

CC @mikioh @bradfitz @ianlancetaylor
@bcmills bcmills added OS-Solaris NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. labels Mar 14, 2019
@ianlancetaylor
Copy link
Contributor

Most likely due to https://golang.org/cl/166497 "runtime, internal/poll, net: report event scanning error on read event". I suspect that Solaris poll is reporting POLLERR if the other side of a Unix socket is closed, although the man page is uninformative on the point. It would be interesting to know whether POLLHUP was also set.

@ianlancetaylor ianlancetaylor added this to the Go1.13 milestone Mar 15, 2019
@mikioh
Copy link
Contributor

mikioh commented Mar 15, 2019

Sure, I think the fix for #30817 also cures this issue.

@gopherbot
Copy link

Change https://golang.org/cl/167777 mentions this issue: runtime, internal/poll: report only critical event scanning error

@mikioh
Copy link
Contributor

mikioh commented Mar 19, 2019 •
edited

Reopen: it seems like there's something-something between Oracle Solaris and SmartOS.

@mikioh mikioh reopened this Mar 19, 2019
@mikioh mikioh changed the title net: TestCloseWrite flaky on SmartOS builder net: TestCloseWrite for SOCK_SEQPACKET failing on SmartOS Mar 19, 2019
@gopherbot
Copy link

Change https://golang.org/cl/167782 mentions this issue: runtime: disable event scanning error reporting on solaris

@golang golang locked and limited conversation to collaborators Mar 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Solaris Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
4 participants
@mikioh @ianlancetaylor @bcmills @gopherbot