New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time: add methods to convert duration to microseconds and milliseconds #30819

Closed

dphan72 wants to merge 1 commit into golang:master from dphan72:duration-conversions

Contributor

dphan72 commented Mar 14, 2019

The return values are integers, as opposed to floats, since the fractionals can be derived from multiplying t.Seconds().

Fixes #28564


          time: add methods to convert duration to microseconds and milliseconds

b843ab7

The return values are integers, as opposed to floats, since the fractionals can be derived from multiplying t.Seconds().

Fixes golang#28564

googlebot added the cla: yes label

gopherbot commented Mar 14, 2019

This PR (HEAD: b843ab7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/167387 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot commented Mar 14, 2019

Message from Robert Griesemer:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/167387.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Mar 14, 2019

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=1d915070

Please don’t reply on this GitHub thread. Visit golang.org/cl/167387.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Mar 14, 2019

Message from Robert Griesemer:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/167387.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Mar 14, 2019

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/167387.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Mar 14, 2019

Message from Brad Fitzpatrick:

Patch Set 1:

Robert, to confirm: you're cool with int64 instead of floats?

Please don’t reply on this GitHub thread. Visit golang.org/cl/167387.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Mar 14, 2019

Message from Robert Griesemer:

Patch Set 1:

Patch Set 1:

Robert, to confirm: you're cool with int64 instead of floats?

Everything below a second is int64 now, and everything above a second is float, which seems ok to me. If one prints ms or us, it's usually whole number, not a fractional ms (otherwise, why not print a us, or use seconds). Rust also returns integers (u128) in these cases.

Please don’t reply on this GitHub thread. Visit golang.org/cl/167387.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          time: add methods to convert duration to microseconds and milliseconds

aa193c0

The return values are integers, as opposed to floats, since the fractionals can be derived from multiplying t.Seconds().

Fixes #28564

Change-Id: I3796227e1f64ead39ff0aacfbdce912d952f2994
GitHub-Last-Rev: b843ab7
GitHub-Pull-Request: #30819
Reviewed-on: https://go-review.googlesource.com/c/go/+/167387
Run-TryBot: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

gopherbot commented Mar 14, 2019

This PR is being closed because golang.org/cl/167387 has been merged.

gopherbot closed this

dphan72 deleted the duration-conversions branch

March 18, 2019 00:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment