Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove GO111MODULE=auto hack before shipping Go 1.13 #30759

Closed
bradfitz opened this issue Mar 12, 2019 · 2 comments
Closed

build: remove GO111MODULE=auto hack before shipping Go 1.13 #30759

bradfitz opened this issue Mar 12, 2019 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge modules NeedsFix The path to resolution is known, but the work has not been done. release-blocker

Comments

@bradfitz
Copy link
Contributor

Remove any GO111MODULE=auto workarounds in x/build before shipping Go 1.13.

See #30752 (comment) and https://golang.org/cl/166888
@bradfitz bradfitz added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. release-blocker modules labels Mar 12, 2019
@bradfitz
Copy link
Contributor Author

/cc @dmitshur (you can reference this issue number if your CL description)

@bradfitz bradfitz mentioned this issue Mar 12, 2019
Closed
@bradfitz
Copy link
Contributor Author

The coordinator no longer does this, so closing.

And #30874 is already open for a more specific case of "auto" hacks.

@golang golang locked and limited conversation to collaborators Mar 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge modules NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bradfitz @gopherbot