Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/dist: add test that Go can bootstrap itself with just-built tree #30758

Closed
bradfitz opened this issue Mar 12, 2019 · 1 comment
Closed

cmd/dist: add test that Go can bootstrap itself with just-built tree #30758

bradfitz opened this issue Mar 12, 2019 · 1 comment
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.13

Comments

@bradfitz
Copy link
Contributor

CL 166985 broke the build, but in a way that the build system didn't detect: it produced a build that couldn't be used to as a GOROOT_BOOTSTRAP directory.

We should add a test (perhaps off by default, except on at least 1 builders, including trybots) that just runs make.bash again using the just-built tree as its GOROOT_BOOTSTRAP.

Because we shard tests and slow tests are scheduled first, it shouldn't affect the overall trybot time.

/cc @mdempsky @bcmills @dmitshur
@bradfitz bradfitz added Testing An issue that has been verified to require only test changes, not just a test failure. help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Mar 12, 2019
@bradfitz bradfitz added this to the Go1.13 milestone Mar 12, 2019
@bradfitz bradfitz mentioned this issue Mar 12, 2019
Closed
@gopherbot
Copy link

Change https://golang.org/cl/167478 mentions this issue: cmd/dist: add a test in misc/reboot to verify that the toolchain can self-bootstrap

@golang golang locked and limited conversation to collaborators Mar 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
2 participants
@bradfitz @gopherbot