Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestLldbPython newly failing (related to enabling modules) #30751

Closed
josharian opened this issue Mar 11, 2019 · 6 comments
Closed

cmd/go: TestLldbPython newly failing (related to enabling modules) #30751

josharian opened this issue Mar 11, 2019 · 6 comments
Labels
FrozenDueToAge GoCommand cmd/go modules NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.13

Comments

@josharian
Copy link
Contributor

On darwin/amd64, running all.bash at tip, I get:

--- FAIL: TestLldbPython (2.12s)
    runtime-lldb_test.go:163: building source exit status 1
        go: cannot find main module; see 'go help modules'
FAIL
FAIL	runtime	26.998s

The test passed this morning. :)

cc @bcmills @jayconrod
@josharian josharian added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 11, 2019
@josharian josharian added this to the Go1.13 milestone Mar 11, 2019
@mikioh
Copy link
Contributor

mikioh commented Mar 20, 2019

It might be better to run "/usr/sbin/DevToolsSecurity -enable" on darwin buildbots by default.

@josharian
Copy link
Contributor Author

Sure. But this was on my local machine. And we don’t want to ask everyone who runs all.bash (often only once) to jump through any hoops. So the test still needs to be resilient.

@gopherbot
Copy link

Change https://golang.org/cl/169725 mentions this issue: runtime: fix TestLldbPython test with modules enabled

@bradfitz
Copy link
Contributor

What does DevToolsSecurity -enable have to do with this?

@bcmills
Copy link
Contributor

bcmills commented Mar 28, 2019

On darwin/amd64, running all.bash at tip

Do we know why this issue didn't show up in the builders? (Should we expand the darwin/amd64 builders in some way to enable them to catch regressions of this test?)

@josharian
Copy link
Contributor Author

Do we know why this issue didn't show up in the builders? (Should we expand the darwin/amd64 builders in some way to enable them to catch regressions of this test?)

Good question. Maybe that's why @mikioh meant by suggesting that we run /usr/sbin/DevToolsSecurity -enable on the builders. I'll open a new issue for that a bit later (have to run now).

@josharian josharian mentioned this issue Mar 28, 2019
Closed
@golang golang locked and limited conversation to collaborators Mar 27, 2020
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge GoCommand cmd/go modules NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
6 participants
@bradfitz @josharian @mikioh @jayconrod @bcmills @gopherbot