Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/tls: expose implemented cipher suites #30739

Closed
wants to merge 1 commit into from
Closed

crypto/tls: expose implemented cipher suites #30739

wants to merge 1 commit into from

Conversation

noneymous
Copy link

Allows to dynamically retrieve a list of available cipher suites. This change allows a variety of applicatoins:

  • Enable all available ciphers programmatically, without hardcoding, and always refering to the latest set of implemented ciphers
  • Filter ciphers by desired flags and use them dynamically, without hardcoding, and always refering to the latest set of implemented ciphers
  • Build application configs for user-decided selection of ciphers to allow

Ciphers are returned as copies, in order to avoid messing up internal stuff.

In contrast to the already discussed solutions, this one reduced the amount of necessary changes. Maintainability will be equal to before. This should not contain any breaking changes, as it only makes former private variables public, respectively, adds functions.

Fixes #30325 and #21167

- Added function to retrieve available cipher suites (returning a cop…
c15a6f6 
…y to avoid accidental manipulation)

- Added function to query cipher by ID if available (returning a copy to avoid accidental manipulation)
- Added function to query cipher by Name if available (returning a copy to avoid accidental manipulation)
- Exposed some cipher flags
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Mar 11, 2019
@noneymous noneymous mentioned this pull request Mar 11, 2019
Closed
@agnivade agnivade mentioned this pull request Mar 26, 2019
Closed
@mvdan
Copy link
Member

mvdan commented Apr 16, 2019

The CLA hasn't been signed in over a month, and the patch now has conflicts; closing for now. If both are solved, feel free to reopen or post a new PR.

@mvdan mvdan closed this Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proposal: crypto/tls: Expose maps for cipher suite IDs/names
3 participants
@noneymous @googlebot @mvdan