Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/cpu: tests fail on nacl #30733

Closed
tklauser opened this issue Mar 11, 2019 · 2 comments
Closed

x/sys/cpu: tests fail on nacl #30733

tklauser opened this issue Mar 11, 2019 · 2 comments
Labels
FrozenDueToAge OS-NaCl GOOS=nacl, Native Client, removed in Go 1.14
Milestone
Unreleased

Comments

@tklauser
Copy link
Member

The x/sys/cpu tests fail on the nacl-386 and nacl-amd64p32 builders:

https://build.golang.org/log/cc4f59f7b4f276707e7bcdde980e0329520f99e7
https://build.golang.org/log/a0e3434d13a77b080e3f6d2d176d96bd368dc1ef

exit status 1
FAIL	golang.org/x/sys/cpu	0.079s
?   	golang.org/x/sys/unix	[no test files]
?   	golang.org/x/sys/windows	[no test files]
?   	golang.org/x/sys/windows/registry	[no test files]

tests failed: exit status 1

when executing via gomote I get

/usr/bin/go_nacl_amd64p32_exec: line 3: go: command not found
sed: -e expression #1, char 0: no previous regular expression
FAIL	golang.org/x/sys/cpu	0.026s
Error running run: exit status 1

/cc @bradfitz @ianlancetaylor
@tklauser tklauser added the OS-NaCl GOOS=nacl, Native Client, removed in Go 1.14 label Mar 11, 2019
@gopherbot gopherbot added this to the Unreleased milestone Mar 11, 2019
@bradfitz
Copy link
Contributor

This builder config might be new. I forget whether we ever tested nacl against subrepos before. Maybe we shouldn't? Especially if we plan to delete nacl anyway (#30439).

As for gomote, perhaps its environment is slightly wrong in its config. Can you test other subrepo nacl stuff via gomote successfully?

@tklauser
Copy link
Member Author

This builder config might be new. I forget whether we ever tested nacl against subrepos before. Maybe
we shouldn't? Especially if we plan to delete nacl anyway (#30439).

I assume it got activated by https://golang.org/cl/166218? In any case it's then probably not worth bothering about x/sys/cpu failing on nacl if it's going to be deleted.

As for gomote, perhaps its environment is slightly wrong in its config. Can you test other subrepo nacl stuff via gomote successfully?

I didn't try any other subrepos as I just wanted to quickly see whether I can get some additional info on the failing test.

@golang golang locked and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-NaCl GOOS=nacl, Native Client, removed in Go 1.14
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @tklauser @gopherbot