Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/cpu: TestPPC64minimalFeatures fails on aix/ppc64 #30732

Closed
tklauser opened this issue Mar 11, 2019 · 2 comments
Closed

x/sys/cpu: TestPPC64minimalFeatures fails on aix/ppc64 #30732

tklauser opened this issue Mar 11, 2019 · 2 comments
Labels
FrozenDueToAge OS-AIX
Milestone
Unreleased

Comments

@tklauser
Copy link
Member

tklauser commented Mar 11, 2019 •
edited 

=== RUN   TestAMD64minimalFeatures
--- PASS: TestAMD64minimalFeatures (0.00s)
=== RUN   TestAVX2hasAVX
--- PASS: TestAVX2hasAVX (0.00s)
=== RUN   TestARM64minimalFeatures
--- PASS: TestARM64minimalFeatures (0.00s)
=== RUN   TestPPC64minimalFeatures
--- FAIL: TestPPC64minimalFeatures (0.00s)
    cpu_test.go:54: IsPOWER8 expected true, got false
=== RUN   TestS390X
--- PASS: TestS390X (0.00s)
FAIL
FAIL	golang.org/x/sys/cpu	0.017s

https://build.golang.org/log/09cf10dbd292a267aae1234be2b2d5c332622d82

We can detect cpu.IsPower8 and cpu.IsPower9 using the getsystemcfg syscall as in package runtime.

/cc @Helflym
@gopherbot gopherbot added this to the Unreleased milestone Mar 11, 2019
@gopherbot
Copy link

Change https://golang.org/cl/166465 mentions this issue: unix: add Getsystemcfg on aix

@gopherbot
Copy link

Change https://golang.org/cl/166466 mentions this issue: cpu: use unix.Getsystemcfg to detect POWER8/POWER9

gopherbot pushed a commit to golang/sys that referenced this issue Mar 11, 2019
@tklauser
unix: add Getsystemcfg on aix
7c207b7 
This will be used to detect POWER8/POWER9 support in x/sys/cpu

Updates golang/go#30732

Change-Id: I10ad6e440920c34c378bf6783417bc09421ff500
Reviewed-on: https://go-review.googlesource.com/c/sys/+/166465
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Clément Chigot <clement.chigot@atos.net>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-AIX
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@tklauser @gopherbot