Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

math/rand: add example for Intn func #30706

Closed
wants to merge 8 commits into from
Closed

math/rand: add example for Intn func #30706

wants to merge 8 commits into from

Conversation

cn007b
Copy link
Contributor

@cn007b cn007b commented Mar 9, 2019 •
edited by agnivade

No description provided.

@cn007b
math/rand: add example for Intn func.
82aea72 
Provide pretty simple example for Intn function.
@cn007b
math/rand: add example for Intn func
f1762a7 
Provide pretty simple example for Intn function.
@cn007b
math/rand: add example for Intn func
ebc7f25 
Provide pretty simple example for Intn function.
@cn007b
math/rand: add example for Intn func
752746d 
Provide pretty simple example for Intn function.
@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Mar 9, 2019
@gopherbot
Copy link

This PR (HEAD: 752746d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/166426 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@cn007b cn007b changed the title Dev kovpak math rand int math/rand: add example for Intn func Mar 9, 2019
@gopherbot
Copy link

Message from Vladimir Kovpak:

Patch Set 3: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166426.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Agniva De Sarker:

Patch Set 4:

(2 comments)

Please also abandon CL 146658.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166426.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/166426.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: e52fcbb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/166426 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@cn007b cn007b mentioned this pull request Mar 12, 2019
Closed
@gopherbot
Copy link

This PR (HEAD: fe05bdd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/166426 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Vladimir Kovpak:

Patch Set 6:

(4 comments)

done

Please don’t reply on this GitHub thread. Visit golang.org/cl/166426.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Vladimir Kovpak:

Patch Set 7: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166426.
After addressing review feedback, remember to publish your drafts!

@agnivade agnivade changed the title math/rand: add example for Intn func math/rand: add example for Intn func Mar 13, 2019
@gopherbot
Copy link

Message from Agniva De Sarker:

Patch Set 8:

Vladimir- you were using gerrit to update the commit message. That doesn't work. https://github.com/golang/go/wiki/GerritBot#how-does-gerritbot-determine-the-final-commit-message

Please don’t reply on this GitHub thread. Visit golang.org/cl/166426.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/166426.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: 2adfcd2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/166426 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Vladimir Kovpak:

Patch Set 9:

(1 comment)

done

Please don’t reply on this GitHub thread. Visit golang.org/cl/166426.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Agniva De Sarker:

Patch Set 10: Run-TryBot+1 Code-Review+1

Looking great now. Thanks for your patience Vladimir !

Please don’t reply on this GitHub thread. Visit golang.org/cl/166426.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 10:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=3d52b16d

Please don’t reply on this GitHub thread. Visit golang.org/cl/166426.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 10:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/3d52b16d/freebsd-amd64-12_0_4de03323.log

Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166426.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 10: TryBot-Result-1

7 of 19 TryBots failed:
Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/3d52b16d/freebsd-amd64-12_0_4de03323.log
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/3d52b16d/linux-amd64_5ec82d42.log
Failed on linux-386: https://storage.googleapis.com/go-build-log/3d52b16d/linux-386_6b4f3a30.log
Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/3d52b16d/openbsd-amd64-64_97e4b02d.log
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/3d52b16d/windows-amd64-2016_ae346528.log
Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/3d52b16d/linux-amd64-race_9ca03df8.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/3d52b16d/windows-386-2008_136b9cf7.log

Consult https://build.golang.org/ to see whether they are new failures.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166426.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 11: Patch Set 10 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/166426.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 11: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/166426.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 11:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=2393ab87

Please don’t reply on this GitHub thread. Visit golang.org/cl/166426.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 11: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166426.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Mar 25, 2019
@cn007b @bradfitz
math/rand: add example for Intn func
9a8979d 
Change-Id: I831ffb5c3fa2872d71def8d8461f0adbd4ae2c1a
GitHub-Last-Rev: 2adfcd2
GitHub-Pull-Request: #30706
Reviewed-on: https://go-review.googlesource.com/c/go/+/166426
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

This PR is being closed because golang.org/cl/166426 has been merged.

@gopherbot gopherbot closed this Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cn007b @gopherbot @googlebot