Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/json: handle anonymous fields #3069

Closed
rsc opened this issue Feb 19, 2012 · 6 comments
Closed

encoding/json: handle anonymous fields #3069

rsc opened this issue Feb 19, 2012 · 6 comments

Comments

@rsc
Copy link
Contributor

rsc commented Feb 19, 2012

Should handle anonymous fields like package xml: at top level of struct.
Right now, disabled so that people do not depend on other behaviors.
@skelterjohn
Copy link
Contributor

Comment 1:

I have a very simple patch (less than 10 extra lines, aside from testing code) that does
this. Any interest?

@skelterjohn
Copy link
Contributor

Comment 2:

Patch viewable here: https://github.com/skelterjohn/json/

@rsc
Copy link
Contributor Author

rsc commented Mar 13, 2012

Comment 3:

"""
I have a very simple patch (less than 10 extra lines, aside from testing
code) that does this. Any interest?
"""
No, not so close to Go 1.  The APIs are set for now.  Thanks, though.
Russ

@krasin
Copy link

krasin commented May 17, 2012

Comment 4:

What's about now? I have been hit by this bug recently.

@skelterjohn
Copy link
Contributor

Comment 5:

Feel free to use my fork, but it's not something that could go into the core libs as is.
It only focuses on the one case that was relevant to my needs - would probably need a
bit of reworking to be more general.

@rsc
Copy link
Contributor Author

rsc commented Sep 11, 2012

Comment 6:

This issue was closed by revision f97bfb9.

Status changed to Fixed.

@rsc rsc added fixed labels Sep 11, 2012
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants