Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/x/text/unicode/bidi: remove generated 'example_test.go' which is build-ignored #30671

Open
leonklingele opened this issue Mar 8, 2019 · 2 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@leonklingele
Copy link
Contributor

example_test.go in internal/x/text/unicode/bidi will never build due to the +build ignore build constraint. Can this file be removed? See also #30021.

@ianlancetaylor
Copy link
Contributor

That's odd. There is no such file in the source package golang.org/x/text/unicode/bidi, and as far as I can tell there never was one. The file first appeared in the main repo in https://golang.org/cl/37111.

The file says that it was generated by gen.go, but I can't figure out how or from what.

CC @mpvl in case he remembers.

@andybons andybons added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 9, 2019
@andybons andybons added this to the Unreleased milestone Mar 9, 2019
@agnivade
Copy link
Contributor

ping @mpvl ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

4 participants