Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/goimports: adds circular imports #30663

Closed
stamblerre opened this issue Mar 7, 2019 · 1 comment
Closed

x/tools/cmd/goimports: adds circular imports #30663

stamblerre opened this issue Mar 7, 2019 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@stamblerre
Copy link
Contributor

goimports will add an import for the package you are currently in if you make a mistake.

Repro:

Open a file in golang.org/x/tools/internal/lsp/source and replace "View" with "source.View". An import for golang.org/x/tools/internal/lsp/source will be added by goimports.
@gopherbot gopherbot added this to the Unreleased milestone Mar 7, 2019
@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 9, 2019
@stamblerre stamblerre removed gopls Issues related to the Go language server, gopls. labels Mar 12, 2019
@gopherbot
Copy link

Change https://golang.org/cl/170238 mentions this issue: imports: fix circular imports

This was referenced Nov 7, 2019
Closed
Closed
@golang golang locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@andybons @stamblerre @gopherbot