Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc/cgo/test: failing TestCrossPackageTests #30646

Closed
YoshikiShibata opened this issue Mar 6, 2019 · 7 comments
Closed

misc/cgo/test: failing TestCrossPackageTests #30646

YoshikiShibata opened this issue Mar 6, 2019 · 7 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.13

Comments

@YoshikiShibata
Copy link

Please answer these questions before submitting your issue. Thanks!

What did you do?

Tried to rebuild the latest tip version with `all.bash*

What did you expect to see?

All tests would pass.

What did you see instead?

##### Testing race detector
ok  	runtime/race	21.266s
ok  	flag	1.064s
ok  	net	1.085s
ok  	os	1.162s
ok  	os/exec	3.086s
ok  	encoding/gob	1.032s
--- FAIL: TestCrossPackageTests (5.05s)
    pkg_test.go:67: go test -short: exit status 2
        # cgotest/issue24161arg
        issue24161arg/def.go:16:85: cannot use _cgo0 (type int) as type _Ctype_CFAllocatorRef in argument to _Cfunc_CFArrayCreate
        issue24161arg/use.go:18:109: cannot use _cgo0 (type int) as type _Ctype_CFAllocatorRef in argument to _Cfunc_CFArrayCreateCopy
        # cgotest/issue24161e2
        issue24161e2/main.go:31:131: cannot use _cgo0 (type int) as type _Ctype_SecKeyRef in argument to _Cfunc_SecKeyCreateSignature
        issue24161e2/main.go:31:131: cannot use _cgo2 (type int) as type _Ctype_CFDataRef in argument to _Cfunc_SecKeyCreateSignature
        # cgotest/issue24161e1
        issue24161e1/main.go:29:131: cannot use _cgo0 (type int) as type _Ctype_SecKeyRef in argument to _Cfunc_SecKeyCreateSignature
        issue24161e1/main.go:29:131: cannot use _cgo2 (type int) as type _Ctype_CFDataRef in argument to _Cfunc_SecKeyCreateSignature
        # cgotest/issue24161e0
        issue24161e0/main.go:26:131: cannot use _cgo0 (type int) as type _Ctype_SecKeyRef in argument to _Cfunc_SecKeyCreateSignature
        issue24161e0/main.go:26:131: cannot use _cgo2 (type int) as type _Ctype_CFDataRef in argument to _Cfunc_SecKeyCreateSignature
        # cgotest/issue24161res
        issue24161res/restype.go:20:85: cannot use _cgo0 (type int) as type _Ctype_CFAllocatorRef in argument to _Cfunc_CFArrayCreate
        FAIL	cgotest [build failed]
FAIL
scatter = 0x4207870
sqrt is: 0
hello from C
exit status 1
FAIL	misc/cgo/test	6.877s
2019/03/07 07:52:40 Failed: exit status 1
ok  	flag	1.026s
ok  	os/exec	3.080s
2019/03/07 07:52:41 FAILED

Does this issue reproduce with the latest release (go1.12)?

N/A

System details

go version devel +1a6c0c6baf Wed Mar 6 21:35:04 2019 +0000 darwin/amd64
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/yoshiki.shibata/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/yoshiki.shibata/gocode"
GOPROXY=""
GORACE=""
GOROOT="/Users/yoshiki.shibata/tools/go"
GOTMPDIR=""
GOTOOLDIR="/Users/yoshiki.shibata/tools/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOROOT/bin/go version: go version devel +1a6c0c6baf Wed Mar 6 21:35:04 2019 +0000 darwin/amd64
GOROOT/bin/go tool compile -V: compile version devel +1a6c0c6baf Wed Mar 6 21:35:04 2019 +0000
uname -v: Darwin Kernel Version 17.7.0: Thu Dec 20 21:47:19 PST 2018; root:xnu-4570.71.22~1/RELEASE_X86_64
ProductName:	Mac OS X
ProductVersion:	10.13.6
BuildVersion:	17G5019
lldb --version: lldb-1000.11.38.2
  Swift-4.2
@ianlancetaylor ianlancetaylor changed the title misc/cgo: failing TestCrossPackageTests misc/cgo/test: failing TestCrossPackageTests Mar 7, 2019
@ianlancetaylor
Copy link
Contributor

Most likely broken by https://golang.org/cl/164897. I'm trying to understand what has gone wrong.

CC @remyoudompheng

@ianlancetaylor ianlancetaylor added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Mar 7, 2019
@ianlancetaylor ianlancetaylor added this to the Go1.13 milestone Mar 7, 2019
@gopherbot
Copy link

Change https://golang.org/cl/165897 mentions this issue: cmd/cgo: use explicit type for arg with bad pointer typedef

@odeke-em
Copy link
Member

odeke-em commented Mar 7, 2019

@ianlancetaylor shall we backport this to Go1.12.1 as https://go-review.googlesource.com/c/go/+/165748 is being backported too?

@ianlancetaylor
Copy link
Contributor

@odeke-em Yes, thanks. I'm going to let these sit for a few more days before doing the backport, to see if we see any other problems. (If we do see other problems a backport is probably not a good idea.)

@gopherbot
Copy link

Change https://golang.org/cl/167497 mentions this issue: [release-branch.go1.12] cmd/cgo: use explicit type for arg with bad pointer typedef

@bradfitz
Copy link
Contributor

@gopherbot, please backport.

This was referenced Mar 13, 2019
Closed
Closed
@gopherbot
Copy link

Backport issue(s) opened: #30815 (for 1.11), #30816 (for 1.12).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

gopherbot pushed a commit that referenced this issue Mar 13, 2019
@ianlancetaylor @andybons
[release-branch.go1.12] cmd/cgo: use explicit type for arg with bad p…
35ddc14 
…ointer typedef

Fixes #30816
Updates #30646

Change-Id: I5b7e986b0588e87b9781cce01445e3c55c06b6fc
Reviewed-on: https://go-review.googlesource.com/c/go/+/165897
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit a6436a5)
Reviewed-on: https://go-review.googlesource.com/c/go/+/167497
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
@Stebalien Stebalien mentioned this issue Mar 16, 2019
Closed
@golang golang locked and limited conversation to collaborators Mar 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
5 participants
@bradfitz @YoshikiShibata @ianlancetaylor @odeke-em @gopherbot