Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/maintner/maintnerd: GoFindTryBot not working, trybots are down #30618

Closed
bradfitz opened this issue Mar 6, 2019 · 1 comment
Closed

x/build/maintner/maintnerd: GoFindTryBot not working, trybots are down #30618

bradfitz opened this issue Mar 6, 2019 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Mar 6, 2019

The trybots are kicked off as a result of a query to maintnerd that ultimately does this Gerrit query:

label:Run-TryBot=1 label:TryBot-Result=0 status:open

But that no longer matches anything:

https://go-review.googlesource.com/q/label:Run-TryBot%253D1+label:TryBot-Result%253D0+status:open

It seems that the meaning of label:TryBot-Result=0 has changed in Gerrit.

We now need to do something else, like label:Run-TryBot=1 status:open but with something to remove the matches containing a TryBot-Result vote of any type.

I naively tried this:

label:Run-TryBot=1 status:open -label:TryBot-Result=-1  -label:TryBot-Result=1

But that doesn't work.

/cc @dborowitz @dmitshur @bcmills @ianlancetaylor
@gopherbot gopherbot added this to the Unreleased milestone Mar 6, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Mar 6, 2019
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 6, 2019
@bradfitz
Copy link
Contributor Author

bradfitz commented Mar 8, 2019

This ended up being due to Gerrit's search index being updated asynchronously and it had got behind.

@bradfitz bradfitz closed this as completed Mar 8, 2019
@golang golang locked and limited conversation to collaborators Mar 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @dmitshur @gopherbot