New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/dist: emit \r in 'env -w' output #3060
Labels
Comments
env.bat can't run in my win7 I:\MinGW\go\src>make.bat # Building C bootstrap tool. cmd/dist '\MinGW\go\bin' 不是内部或外部命令,也不是可运行的程序 或批处理文件。 '86' 不是内部或外部命令,也不是可运行的程序 或批处理文件。 'dows' 不是内部或外部命令,也不是可运行的程序 或批处理文件。 'CH' 不是内部或外部命令,也不是可运行的程序 或批处理文件。 'windows' 不是内部或外部命令,也不是可运行的程序 或批处理文件。 'R' 不是内部或外部命令,也不是可运行的程序 或批处理文件。 系统找不到指定的路径。 The chinese above means comannds 86, dows, etc can't be found... |
I'm hesitant to add \r to all of dist's output but we can easily add it to the env -w output. Owner changed to @rsc. Status changed to Accepted. |
This issue was closed by revision 792518c. Status changed to Fixed. |
rsc
added a commit
that referenced
this issue
May 11, 2015
««« backport 108165c03c70 cmd/dist: emit \r in env -w output go tool dist env -w is supposed to print a Windows batch file. Normally Windows will execute batch files without \r before \n, but issue 3060 reports that if the file ends up containing paths written in Chinese, Windows 7 cannot execute it without the \r. So add the \r. Fixes #3060. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6498120 »»»
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The text was updated successfully, but these errors were encountered: