Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/gopls: define fields for "initializationOptions" #30578

Closed
stamblerre opened this issue Mar 4, 2019 · 3 comments
Closed

x/tools/cmd/gopls: define fields for "initializationOptions" #30578

stamblerre opened this issue Mar 4, 2019 · 3 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Unreleased

Comments

@stamblerre
Copy link
Contributor

This initialize request for LSP allows for arbitrary initialization options to be provided to the server from the editor (https://microsoft.github.io/language-server-protocol/specification#initialize). We should determine what these options should look like, so that we can provide a clear spec to editors.

This issue was originally raised by @mattn in golang.org/cl/164779, and the suggestion was to offer an option to disable diagnostics.
@mattn
Copy link
Member

mattn commented Mar 8, 2019

At least, I want to add diagnostics to off the feature since gopls often crash.

2019/03/08 14:07:12:["<---(stderr)",2,"go-lang",["panic: runtime error: invalidmemory address or nil pointer dereference","[signal 0xc0000005 code=0x0 addr=0x68 pc=0x714014]","","goroutine 20 [running]:","golang.org/x/tools/internal/lsp/source.Diagnostics(0x8dd560, 0xc00005a080, 0x8dd6e0, 0xc000054aa0, 0xc0001a3400, 0x44, 0x117, 0x117, 0xc0000c1f30)","\tC:/Users/mattn/go/src/golang.org/x/tools/internal/lsp/source/diagnostics.go:64 +0xd4","golang.org/x/tools/internal/lsp.(*server).cacheAndDiagnose.func1(0x8dd560, 0xc00005a080, 0xc00003ad40, 0xc0001a3400, 0x44)","\tC:/Users/mattn/go/src/golang.org/x/tools/internal/lsp/diagnostics.go:24 +0x88","created by golang.org/x/tools/internal/lsp.(*server).cacheAndDiagnose","\tC:/Users/mattn/go/src/golang.org/x/tools/internal/lsp/diagnostics.go:23 +0x143",""]]

@stamblerre
Copy link
Contributor Author

That's what I figured, but our goal is to make gopls more reliable, rather than turn off features. I have a few pending CLs that should help with that, but if you are still seeing consistent crashes I would prefer that we investigate them rather than just turn off a key feature.

@julieqiu julieqiu added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Mar 11, 2019
@stamblerre stamblerre changed the title cmd/gopls: define fields for "initializationOptions" x/tools/cmd/gopls: define fields for "initializationOptions" Mar 12, 2019
@gopherbot gopherbot added this to the Unreleased milestone Mar 12, 2019
@stamblerre stamblerre added gopls Issues related to the Go language server, gopls. and removed gopls Issues related to the Go language server, gopls. labels Mar 12, 2019
@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@golang golang locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@mattn @stamblerre @julieqiu @gopherbot