Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/devapp: broken link on reviews page #30575

Closed
bcmills opened this issue Mar 4, 2019 · 2 comments
Closed

x/build/devapp: broken link on reviews page #30575

bcmills opened this issue Mar 4, 2019 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Mar 4, 2019

https://dev.golang.org/reviews includes an entry linking to https://go-review.googlesource.com/93515.
The latter link is currently a 404.
Perhaps we need to filter out deleted CLs?

CC @andybons
@gopherbot gopherbot added this to the Unreleased milestone Mar 4, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Mar 4, 2019
@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 4, 2019
@andybons
Copy link
Member

andybons commented Mar 5, 2019

Sigh, yeah a consequence of #22635.

@andybons
Copy link
Member

andybons commented Oct 7, 2019

Added a list of deleted CLs. This shouldn't show up anymore.

@andybons andybons closed this as completed Oct 7, 2019
@golang golang locked and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@andybons @bcmills @gopherbot