Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc/cgo: fix gcc -shared and -static with aix/ppc64 #30565

Open
Helflym opened this issue Mar 4, 2019 · 2 comments
Open

misc/cgo: fix gcc -shared and -static with aix/ppc64 #30565

Helflym opened this issue Mar 4, 2019 · 2 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unplanned

Comments

@Helflym
Copy link
Contributor

Helflym commented Mar 4, 2019

The cmd/dist tests using either -shared or -static doesn't work as it is. They need to be adapt to AIX gcc or ld specificities.
Therefore, https://go-review.googlesource.com/c/go/+/164018 disables tests related to them.

This is a tracking-bug.
@gopherbot
Copy link

Change https://golang.org/cl/164018 mentions this issue: cmd/dist, misc/cgo: enable tests for aix/ppc64

@julieqiu julieqiu added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 11, 2019
gopherbot pushed a commit that referenced this issue Mar 20, 2019
@ianlancetaylor
cmd/dist, misc/cgo: enable tests for aix/ppc64
125d187 
Some cgo tests aren't yet available on aix/ppc64.
-shared and -static don't work as expected and will be fixed latter.

Updates #30565

Change-Id: Ic59cabe685cb1cbdf89a8d1d1a1d2c4b0e8ef442
Reviewed-on: https://go-review.googlesource.com/c/go/+/164018
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/169020 mentions this issue: misc/cgo: enable testso and testsovar on aix/ppc64

gopherbot pushed a commit that referenced this issue Mar 27, 2019
@ianlancetaylor
misc/cgo: enable testso and testsovar on aix/ppc64
53c9c06 
On AIX, shared objects must be wrapped under an archive file.

For testso, creating libcgosotest with an extern symbol isn't
AIX-friendly. By default, ld will block such behavior. Rather than
forcing ld to work as on Linux and using the run-time linking,
goCallback became a function pointer which is set by setCallback().

Updates #30565

Change-Id: I455ab32faddd41f1b0c84cc9e503788044ad49b2
Reviewed-on: https://go-review.googlesource.com/c/go/+/169020
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@seankhliao seankhliao added this to the Unplanned milestone Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
4 participants
@julieqiu @gopherbot @seankhliao @Helflym