Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: MacOS binaries invalid for eventual Apple Notary [1.12 backport] #30526

Closed
gopherbot opened this issue Mar 1, 2019 · 14 comments
Closed

cmd/go: MacOS binaries invalid for eventual Apple Notary [1.12 backport] #30526

gopherbot opened this issue Mar 1, 2019 · 14 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.12.6

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #30488 to be considered for backport to the next 1.12 minor release.

@gopherbot please open backport issues
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 1, 2019
@gopherbot gopherbot mentioned this issue Mar 1, 2019
Closed
@gopherbot gopherbot added this to the Go1.12.1 milestone Mar 1, 2019
@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Mar 2, 2019
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 2, 2019
@macetw
Copy link

macetw commented Mar 12, 2019

How can I be recognized as the assignee, and with label "NeedsFix?"

@ianlancetaylor
Copy link
Contributor

@gopherbot please add label NeedsFix

@gopherbot gopherbot added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 12, 2019
@ianlancetaylor
Copy link
Contributor

@gopherbot please assign to macetw

@ianlancetaylor
Copy link
Contributor

Well, at least the label request worked.

@ianlancetaylor
Copy link
Contributor

I can't seem to assign the issue to you anyhow. I wouldn't worry about it.

@andybons andybons modified the milestones: Go1.12.1, Go1.12.2 Mar 14, 2019
@andybons andybons modified the milestones: Go1.12.2, Go1.12.3, Go1.12.4, Go1.12.5 Apr 5, 2019
@andybons andybons modified the milestones: Go1.12.5, Go1.12.6 May 6, 2019
@pieterclaerhout
Copy link

Any idea when this will be released?

We're actually waiting for this fix to be able to notarize our binaries for macOS. Since Apple will be pushing this after WWDC beginning of june, it would be awesome to be ready…

@gopherbot
Copy link
Author

Change https://golang.org/cl/175919 mentions this issue: [release-branch.go1.12] cmd/link/internal/ld: bump macOS and macOS SDK version to 10.9

gopherbot pushed a commit that referenced this issue May 8, 2019
@eliasnaur @bradfitz
[release-branch.go1.12] cmd/link/internal/ld: bump macOS and macOS SD…
cdb7765 
…K version to 10.9

Satisfies the Apple Notary.

Fixes #30526

Change-Id: I91cf2d706a3ebe79bafdb759a0d32266ed6b9096
Reviewed-on: https://go-review.googlesource.com/c/go/+/175918
Run-TryBot: Elias Naur <mail@eliasnaur.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/175919
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link
Author

Closed by merging cdb7765 to release-branch.go1.12.

@pieterclaerhout
Copy link

What's the target release date of go 1.12.6?

@ianlancetaylor
Copy link
Contributor

Likely around June 1. (CC @andybons)

@andybons
Copy link
Member

Ian is correct. Around June 1

@pieterclaerhout
Copy link

Hi, any update on the availability of Go 1.12.6?

@dmitshur
Copy link
Contributor

@pieterclaerhout The release should be available tomorrow, June 11th.

@pieterclaerhout
Copy link

I can confirm that with Go 1.12.6, notarization now works correctly!

@golang golang locked and limited conversation to collaborators Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.12.6
Development

No branches or pull requests
7 participants
@pieterclaerhout @andybons @dmitshur @ianlancetaylor @macetw @bcmills @gopherbot