Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/lsp: do not complete within multiline strings #30477

Closed
stamblerre opened this issue Feb 28, 2019 · 1 comment
Closed

x/tools/internal/lsp: do not complete within multiline strings #30477

stamblerre opened this issue Feb 28, 2019 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Suggested Issues that may be good for new contributors looking for work to do.
Milestone
Unreleased

Comments

@stamblerre
Copy link
Contributor

We should not offer completion within string literals.
@gopherbot gopherbot added this to the Unreleased milestone Feb 28, 2019
@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 28, 2019
@stamblerre stamblerre added gopls Issues related to the Go language server, gopls. Suggested Issues that may be good for new contributors looking for work to do. and removed gopls Issues related to the Go language server, gopls. labels Mar 12, 2019
@gopherbot
Copy link

Change https://golang.org/cl/167857 mentions this issue: cmd/lsp: skip completion in string literals

movie-travel-code pushed a commit to elastic/go-langserver that referenced this issue Mar 19, 2019
@marwan-at-work
cmd/lsp: skip completion in string literals
bf34597 
This CL ensures that a "." inside a string literal will return an empty
completion list.

Fixes golang/go#30477

Change-Id: I1442d0acab4c12a829047805f745c4729d69c208
Reviewed-on: https://go-review.googlesource.com/c/tools/+/167857
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
@golang golang locked and limited conversation to collaborators Mar 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bcmills @stamblerre @gopherbot