Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: random errors on sync.Once running on MacOS Mojave or High Serra [1.12 backport] #30470

Closed
gopherbot opened this issue Feb 28, 2019 · 2 comments
Closed

sync: random errors on sync.Once running on MacOS Mojave or High Serra [1.12 backport] #30470

gopherbot opened this issue Feb 28, 2019 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.12.1

Comments

@gopherbot
Copy link

@bcmills requested issue #30453 to be considered for backport to the next 1.12 minor release.

@gopherbot, please backport to 1.12: this is an apparent regression in a core synchronization library.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 28, 2019
@gopherbot gopherbot mentioned this issue Feb 28, 2019
Closed
@gopherbot gopherbot added this to the Go1.12.1 milestone Feb 28, 2019
@gopherbot
Copy link
Author

Change https://golang.org/cl/164629 mentions this issue: [release-branch.go1.12] runtime: scan defer closure in stack scan

gopherbot pushed a commit that referenced this issue Mar 1, 2019
@cherrymui @ianlancetaylor
[release-branch.go1.12] runtime: scan defer closure in stack scan
91fd14b 
With stack objects, when we scan the stack, it scans defers with
tracebackdefers, but it seems to me that tracebackdefers doesn't
include the func value itself, which could be a stack allocated
closure. Scan it explicitly.

Alternatively, we can change tracebackdefers to include the func
value, which in turn needs to change the type of stkframe.

Updates #30453.
Fixes #30470.

Change-Id: I55a6e43264d6952ab2fa5c638bebb89fdc410e2b
Reviewed-on: https://go-review.googlesource.com/c/164118
Reviewed-by: Keith Randall <khr@golang.org>
(cherry picked from commit 4f4c2a7)
Reviewed-on: https://go-review.googlesource.com/c/164629
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot
Copy link
Author

Closed by merging 91fd14b to release-branch.go1.12.

@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Mar 1, 2019
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 1, 2019
@dims dims mentioned this issue Mar 13, 2019
Merged
@golang golang locked and limited conversation to collaborators Feb 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.12.1
Development

No branches or pull requests
2 participants
@bcmills @gopherbot