Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: wrong link in release history #30451

Closed
mariecurried opened this issue Feb 28, 2019 · 4 comments
Closed

doc: wrong link in release history #30451

mariecurried opened this issue Feb 28, 2019 · 4 comments
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.

Comments

@mariecurried
Copy link

What did you do?

I visited the release history page for the Go language.

What did you expect to see?

I expected the minor revisions' links to be correct.

What did you see instead?

Instead, the link to the go1.6.4 milestone does not exist and in its place there is a link to the 1.7.4 milestone.
The same happens with go1.7.6 and go1.5.4.

@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 28, 2019
@bcmills bcmills self-assigned this Feb 28, 2019
@ALTree
Copy link
Member

ALTree commented Mar 2, 2019

This seems to be intentional. The 1.6.4 paragraph says:

It contains the same fixes as Go 1.7.4 and was released at the same time. See the Go 1.7.4 milestone on our issue tracker for details.

so it links to the 1.7.4 milestone, since it's basically the same thing with the same two patches. While it's true that more recently we started linking to the two distinct milestones, it doesn't make much difference IMO.

@mariecurried
Copy link
Author

Yeah, you are right. Somehow I missed the part that states:

It contains the same fixes as Go 1.7.4 and was released at the same time

🤦‍♂️
I leave it up to you if you think this should be closed or not.

@agnivade
Copy link
Contributor

agnivade commented Mar 4, 2019

Well, the actual 1.6.4 milestone contains 2 different fixes. Perhaps they should be removed from that milestone then ? https://github.com/golang/go/issues?utf8=%E2%9C%93&q=milestone%3AGo1.6.4

@ALTree
Copy link
Member

ALTree commented Jul 25, 2019

I would leave them, the official link points to 1.7.4 so they won't mislead anyone. OTOH this issue can be closed, since the link is correct.

@ALTree ALTree closed this as completed Jul 25, 2019
@golang golang locked and limited conversation to collaborators Jul 24, 2020
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

5 participants