Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: darwin-386 build is broken #30444

Closed
bradfitz opened this issue Feb 27, 2019 · 2 comments
Closed

crypto/x509: darwin-386 build is broken #30444

bradfitz opened this issue Feb 27, 2019 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Darwin Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone
Go1.11.6

Comments

@bradfitz
Copy link
Contributor

https://go-review.googlesource.com/c/go/+/162860 broke the darwin-386 builder:

https://build.golang.org/log/d1a0dbe3428c41dfefc1a4d7b4d50735198fe20b

Building packages and commands for darwin/386.
# crypto/x509
src/crypto/x509/root_cgo_darwin.go:218:55: warning: values of type 'SInt32' should not be used as format arguments; add an explicit cast to 'int' instead [-Wformat]
go build crypto/x509: C compiler warning promoted to error on Go builders
go tool dist: FAILED: /private/var/folders/dx/k53rs1s93538b4x20g46cj_w0000gn/T/workdir/go/pkg/tool/darwin_386/go_bootstrap install -gcflags=all= -ldflags=all= std cmd: exit status 1

/cc @FiloSottile @dmitshur @ianlancetaylor
@bradfitz bradfitz added NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) labels Feb 27, 2019
@bradfitz bradfitz added this to the Go1.11.6 milestone Feb 27, 2019
@gopherbot
Copy link

Change https://golang.org/cl/164240 mentions this issue: [release-branch.go1.11] crypto/x509: explicitly cast printf format argument

@gopherbot
Copy link

Closed by merging 8390781 to release-branch.go1.11.

gopherbot pushed a commit that referenced this issue Feb 27, 2019
@tklauser @FiloSottile
[release-branch.go1.11] crypto/x509: explicitly cast printf format ar…
8390781 
…gument

After CL 128056 the build fails on darwin/386 with

  src/crypto/x509/root_cgo_darwin.go:218:55: warning: values of type 'SInt32' should not be used as format arguments; add an explicit cast to 'int' instead [-Wformat]
  go build crypto/x509: C compiler warning promoted to error on Go builders

Fix the warning by explicitly casting the argument to an int as
suggested by the warning.

Fixes #30444

Change-Id: Icb6bd622a543e9bc5f669fd3d7abd418b4a8e579
Reviewed-on: https://go-review.googlesource.com/c/152958
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit ec0077c)
Reviewed-on: https://go-review.googlesource.com/c/164240
Run-TryBot: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Feb 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Darwin Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Milestone
Go1.11.6
Development

No branches or pull requests
3 participants
@bradfitz @FiloSottile @gopherbot