Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: Go 2: add append variant that modifies its first argument instead of returning result #30438

Closed
ramikalai opened this issue Feb 27, 2019 · 4 comments
Closed

proposal: Go 2: add append variant that modifies its first argument instead of returning result #30438

ramikalai opened this issue Feb 27, 2019 · 4 comments
Labels
FrozenDueToAge LanguageChange Proposal v2 A language change or incompatible library change
Milestone
Proposal

Comments

@ramikalai
Copy link

Proposal

A wrapper on the append function that can append to a slice by reference

Currently

a := []int{1,2,3}
b := []int{4,5,6}
a = append(a,b...)

fmt.Println(a)

Append(ByReference)

a := []int{1,2,3}
b := []int{4,5,6}
append(a,b...)

fmt.Println(a)

Output For Both

[1 2 3 4 5 6]

Why?

This would be ideal in a situation where a slice is passed down until reaching an append.
Currently, the append will return a slice which needs to be propagated back up and set on the original variable.

Clearly this is not ideal when you could simply append by reference and not need to pass the slice back.

Suggested Implementation

This can be achieved by creating a wrapper for the current append function which will overwrite the pointer of the original object with that of the one returned from the current append and will garbage collect the original slice.
@bradfitz bradfitz changed the title Append By Reference proposal: language: add append variant that modifies its first argument instead of returning result Feb 27, 2019
@gopherbot gopherbot added this to the Proposal milestone Feb 27, 2019
@ianlancetaylor ianlancetaylor changed the title proposal: language: add append variant that modifies its first argument instead of returning result proposal: Go 2: add append variant that modifies its first argument instead of returning result Feb 27, 2019
@ianlancetaylor ianlancetaylor added the v2 A language change or incompatible library change label Feb 27, 2019
@ianlancetaylor
Copy link
Contributor

This would change append from being a builtin but otherwise ordinary function into being an operation that implicitly takes the address of its first argument. Actually, it's even more complicated than that because presumably we would want

append(f(), 1)

to work. This would make append unlike anything else in the language, which is not a good thing.

@OneOfOne
Copy link
Contributor

Why would that be better than something like https://play.golang.org/p/edcz_xp00kZ?

@ramikalai
Copy link
Author

Why would that be better than something like https://play.golang.org/p/edcz_xp00kZ?

@OneOfOne this could work as well. In my mind it would be more generic and part of the standard library rather than a method on a specific slice type.

Effectively, a generic method on any slice type that wraps the standard append function in a similar fashion to your example.

It might be complicated though as this method will need to be written on a slice of type empty interface to be compatible with any type slice and then have some sort of type assertion.

If we had this for slices of builtin types, this could be a good first step and then one can extend that method for custom types through an interface

@ianlancetaylor
Copy link
Contributor

This could in principle change the behavior of existing code. And nothing else in the language works like this. We are not going to make this change.

@golang golang locked and limited conversation to collaborators Mar 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge LanguageChange Proposal v2 A language change or incompatible library change
Projects
None yet
Milestone
Proposal
Development

No branches or pull requests
5 participants
@bradfitz @OneOfOne @ianlancetaylor @gopherbot @ramikalai