Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/url: url.Parse returns an error while parsing 192.168.210.111:8080 #30362

Closed
dmigwi opened this issue Feb 23, 2019 · 1 comment
Closed

net/url: url.Parse returns an error while parsing 192.168.210.111:8080 #30362

dmigwi opened this issue Feb 23, 2019 · 1 comment

Comments

@dmigwi
Copy link

dmigwi commented Feb 23, 2019

What version of Go are you using (go version)?

$ go version go1.11.5 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/dmigwi/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/dmigwi/work/app/golang"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/dmigwi/work/app/golang/src/example/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build331081696=/tmp/go-build -gno-record-gcc-switches"

What did you do?

While validating a number of urls and some of them returned errors. Here is the sample program.
https://play.golang.org/p/zl8cg1tKkEi

What did you expect to see?

list := []string{"mydomain.herokuapp.com:7777", "192.168.210.111:8080"}

In the above slice both elements were supposed to a fail or be successfully parsed.

What did you see instead?

Parsing the second slice element returned the following error:
parse 192.168.210.111:8080: first path segment in URL cannot contain colon

@dmigwi
Copy link
Author

dmigwi commented Feb 23, 2019

Also referenced here #21415

@dmigwi dmigwi closed this as completed Feb 23, 2019
@golang golang locked and limited conversation to collaborators Feb 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants