Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gopherbot: doesn't close backport issues for first major release #30342

Closed
dmitshur opened this issue Feb 21, 2019 · 2 comments
Closed

x/build/cmd/gopherbot: doesn't close backport issues for first major release #30342

dmitshur opened this issue Feb 21, 2019 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

GopherBot has a "close cherry pick issues" task. It closes cherry-pick issues when CLs are merged to release branches, as GitHub only does that on merge to master.

It works when backporting into patch releases like 1.12.1, 1.12.2, 1.12.3, etc., but not when backporting into 1.12.

This happened in #30314 (comment).

I wrote an explanation for why it happens in #30314 (comment). I have a fix, will send CL.

/cc @agnivade @bradfitz @andybons
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Feb 21, 2019
@dmitshur dmitshur self-assigned this Feb 21, 2019
@gopherbot gopherbot added this to the Unreleased milestone Feb 21, 2019
@gopherbot
Copy link

Change https://golang.org/cl/163205 mentions this issue: cmd/gopherbot: support closing major release cherry-pick issues

@dmitshur dmitshur mentioned this issue Feb 28, 2019
Closed
@dmitshur
Copy link
Contributor Author

dmitshur commented Mar 1, 2019

This is deployed now, and gopherbot is doing the right thing, as can be seen at #30314 (comment).

@golang golang locked and limited conversation to collaborators Feb 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot