Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all.bash: leaves $GOROOT/nonexistentpath behind #30338

Closed
mikioh opened this issue Feb 21, 2019 · 6 comments
Closed

all.bash: leaves $GOROOT/nonexistentpath behind #30338

mikioh opened this issue Feb 21, 2019 · 6 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@mikioh
Copy link
Contributor

mikioh commented Feb 21, 2019

What version of Go are you using (go version)?

$ go version
go version devel +889aa5eb98

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

It happens on most of the supported platforms.

GOMOD=""

What did you do?

Run all.bash at $GOROOT/src

What did you expect to see?

The command "git status" reports "no untracked files"

What did you see instead?

The command "git status" reports there's one untracked file: $GOROOT/nonexistentpath

Fortunately, this doesn't happen with Go 1.12. Looks like the path comes from $GOPATH in run.bash.

@mikioh mikioh added this to the Go1.13 milestone Feb 21, 2019
@mvdan
Copy link
Member

mvdan commented Feb 21, 2019

Looks like the GOPATH line in run.bash has been there since 2a0d7e2 in early 2017, so I'm not sure what could be causing this.

I think #30316 would have detected this. /cc @bcmills @bradfitz @dmitshur

@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 21, 2019
@ianlancetaylor
Copy link
Contributor

ianlancetaylor commented Feb 22, 2019

I saw it a couple of times but I don't see it any more.

When I did see it there was a single file there nonexistentpath/pkg/mod/cache/lock.

@mikioh
Copy link
Contributor Author

mikioh commented Feb 22, 2019

Sorry, I didn't mention important information: I didn't set GO111MODULE on both go1.12 and tip, that means GOMOD="", so cmd/go behaves as it wants.

@bcmills
Copy link
Contributor

bcmills commented Feb 22, 2019

I'm not sure what the cause of this is, but at least one of the changes in the stack for #30228 should fix it.

I'll revisit once that is resolved.

@bcmills bcmills self-assigned this Feb 22, 2019
@dmitshur
Copy link
Contributor

Somewhat related issue: #30221.

@bcmills bcmills changed the title cmd/go: leaves $GOROOT/nonexistentpath behind all.bash: leaves $GOROOT/nonexistentpath behind Mar 7, 2019
@bcmills
Copy link
Contributor

bcmills commented Mar 14, 2019

This should be fixed now. Please reopen if you see it again.

@bcmills bcmills closed this as completed Mar 14, 2019
@golang golang locked and limited conversation to collaborators Mar 13, 2020
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

6 participants