Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/tls: Expose maps for cipher suite IDs/names #30326

Closed
wants to merge 1 commit into from

Conversation

JAORMX
Copy link

@JAORMX JAORMX commented Feb 20, 2019

These are utility functions that allow you to get maps that translate from Cipher Suite names towards IDs and vice versa.

The main purpose of this is to be able to easily parse such configurations for HTTP(s) servers without much boiler plate code.

Fixes: #30325

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Feb 20, 2019
@gopherbot
Copy link

This PR (HEAD: f01fc49) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/163119 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@JAORMX JAORMX changed the title crypto: Create method for parsing string of cipher suites crypto/tls: Create method for parsing string of cipher suites Feb 20, 2019
@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/163119.
After addressing review feedback, remember to publish your drafts!

These are utility functions that allow you to get maps that translate
from Cipher Suite names towards IDs and vice versa.

The main purpose of this is to be able to easily parse such
configurations for HTTP(s) servers without much boiler plate code.

Fixes: golang#30325
@gopherbot
Copy link

This PR (HEAD: 6d13a8f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/163119 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@JAORMX JAORMX changed the title crypto/tls: Create method for parsing string of cipher suites crypto/tls: Expose maps for cipher suite IDs/names Feb 20, 2019
@noneymous
Copy link

noneymous commented Mar 6, 2019

Thank you @JAORMX for this pull request, Having this change would be awesome.

I often have problems in GO where some go packages holds some information I'd like to access, but I can't because its private and there is no way araound. Okay, technically, in this case the data is accessible, but not in an dynamic way. I need to know the constants and i cannot just query them.

This really sucks. From a builders point of view I understand, that some information is not necessary and can be unknown. But i do use Go for testing (respectively, building security checks), and such information is elemntary to me.

I have a similar problem with the SSH package. It holds information about what cipher suites are supported by a remote server, but I can't access it ^^

@JAORMX
Copy link
Author

JAORMX commented Mar 6, 2019

@noneymous thanks for checking this out! Feel free to jump in #30325 where the discussion about this is happening.

@JAORMX JAORMX closed this Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants