Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: x/net/dns/dnstest: new package and refurbish test cases in net #30323

Closed
mikioh opened this issue Feb 20, 2019 · 2 comments
Closed
Labels
FrozenDueToAge Proposal WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone

Comments

@mikioh
Copy link
Contributor

mikioh commented Feb 20, 2019

This is a proposal to make a package containing helpers for DNS stub resolver testing and to refurbish the DNS test cases in the package net of the standard library, the same as #13295.

Problem: For historical reasons, the package net hasn't been had self-contained, functional test cases for the built-in DNS stub resolver. As a consequence, it has become a normal situation that people modify the code, pray for the luck and face regressions and neglected issues.

Solution: To have enough functional test cases with the support of the dnstest package. The package dnstest implements DNS zone information parsers, DNS transport mocks and DNS recursive server mocks to help construct a bit complicated test cases without relying on external resources, as in, "traverse a tree, stop with NXDOMAIN or transport failure, and return a correct set of records with an appropriate error value even if it's a single name query with multiple concurrent racers; note that the circumstances have a middlebox that throttles concurrent DNS queries to the same name and operate split DNS: some recursive servers are for internal, others are for external and the others are for both."

@gopherbot gopherbot added this to the Proposal milestone Feb 20, 2019
@rsc
Copy link
Contributor

rsc commented Feb 27, 2019

A package named x/net/dns/dnstest seems fine but you haven't said what the API will be. What is the expected API?

@bcmills bcmills added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Feb 28, 2019
@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@golang golang locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge Proposal WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Development

No branches or pull requests

4 participants