Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/nettest: mark test helper functions #30295

Closed
santhosh-tekuri opened this issue Feb 18, 2019 · 1 comment
Closed

x/net/nettest: mark test helper functions #30295

santhosh-tekuri opened this issue Feb 18, 2019 · 1 comment
Labels
FrozenDueToAge help wanted
Milestone
Unreleased

Comments

@santhosh-tekuri
Copy link
Contributor

What version of Go are you using (go version)?

$ go version
go version go1.10.3 windows/amd64

Does this issue reproduce with the latest release?

helper methods in conntest.go should have been marked with t.Helper()
it makes consumers of this package easier.

I can send CL, if you agree
@gopherbot gopherbot added this to the Unreleased milestone Feb 18, 2019
@gopherbot
Copy link

Change https://golang.org/cl/162925 mentions this issue: nettest: mark test helper methods

@santhosh-tekuri santhosh-tekuri changed the title x/net/nettest: mark test helper methods x/net/nettest: mark test helper functions Feb 19, 2019
@golang golang locked and limited conversation to collaborators Feb 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@mikioh @santhosh-tekuri @gopherbot