Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/asm: improve DATA size operand validation #30269

Closed
josharian opened this issue Feb 16, 2019 · 1 comment
Closed

cmd/asm: improve DATA size operand validation #30269

josharian opened this issue Feb 16, 2019 · 1 comment
Milestone

Comments

@josharian
Copy link
Contributor

DATA instructions currently accept the values 1, 2, 4, 8 as sizes; the acceptable sizes are further restricted to 4 and 8 for float constants.

This is both too restrictive and not restrictive enough: string constants may reasonably have any length, and address constants should really only accept pointer-length sizes.

I have a simple CL ready to mail when the tree open that improves the situation. This issue is for any discussion that might be required.

cc @robpike

@josharian josharian added this to the Go1.13 milestone Feb 16, 2019
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/163747 mentions this issue: cmd/asm: improve DATA size operand validation

@golang golang locked and limited conversation to collaborators Feb 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants