Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: no newline after note about old Go version #30263

Closed
eliasnaur opened this issue Feb 15, 2019 · 3 comments
Closed

cmd/go: no newline after note about old Go version #30263

eliasnaur opened this issue Feb 15, 2019 · 3 comments
Labels
FrozenDueToAge

Comments

@eliasnaur
Copy link
Contributor

What version of Go are you using (go version)?

$ go version
go version devel +ffd096db2b Wed Feb 13 05:35:45 2019 +0000 linux/amd64

Does this issue reproduce with the latest release?

Yes

What did you do?

$ go mod init go1.13mod
$ go mod edit -go 1.13
$ cat main.go
package main

func main() {
	Compile error
}
$ go run .
# go113mod
./main.go:4:10: syntax error: unexpected error at end of statement
note: module requires Go 1.13$ # note that there is no newline after this last line.

What did you expect to see?

A newline after the "note: module requires Go 1.13".

What did you see instead?

No newline after the "note: module requires Go 1.13".
@eliasnaur
Copy link
Contributor Author

@ianlancetaylor @bcmills perhaps this is ugly enough to be fixed for Go 1.12.

@gopherbot
Copy link

Change https://golang.org/cl/162957 mentions this issue: cmd/go: add newline after module-requires-version message

@gopherbot
Copy link

Change https://golang.org/cl/162958 mentions this issue: [release-branch.go1.12] cmd/go: add newline after module-requires-version message

gopherbot pushed a commit that referenced this issue Feb 15, 2019
@ianlancetaylor
[release-branch.go1.12] cmd/go: add newline after module-requires-ver…
96d3920 
…sion message

Updates #30263

Change-Id: Iefb3d8baf815c19eaf915a59048e1da799ca0cdf
Reviewed-on: https://go-review.googlesource.com/c/162957
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
(cherry picked from commit e1acd85)
Reviewed-on: https://go-review.googlesource.com/c/162958
nebulabox pushed a commit to nebulabox/go that referenced this issue Feb 18, 2019
@ianlancetaylor @nebulabox
cmd/go: add newline after module-requires-version message
2ce4b8e 
Fixes golang#30263

Change-Id: Iefb3d8baf815c19eaf915a59048e1da799ca0cdf
Reviewed-on: https://go-review.googlesource.com/c/162957
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
nebulabox pushed a commit to nebulabox/go that referenced this issue Feb 20, 2019
@ianlancetaylor @nebulabox
cmd/go: add newline after module-requires-version message
74b63e5 
Fixes golang#30263

Change-Id: Iefb3d8baf815c19eaf915a59048e1da799ca0cdf
Reviewed-on: https://go-review.googlesource.com/c/162957
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
@golang golang locked and limited conversation to collaborators Feb 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eliasnaur @gopherbot