Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: request output of go list -m all in the issue template #30256

Open
bcmills opened this issue Feb 15, 2019 · 3 comments
Open

meta: request output of go list -m all in the issue template #30256

bcmills opened this issue Feb 15, 2019 · 3 comments
Labels
Community NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Feb 15, 2019

As @FiloSottile notes in #30241 (comment):

I actually don't want to have to figure out if a crypto/tls internal failure is due to a replaced chacha20poly1305.

But of course the same is true for x-repo interdependencies in general: if someone is reporting an issue against, say, x/tools or x/net, it would be really helpful to know the exact version in which they found the issue, and whether any of the dependencies involved have been locally modified.

I propose that we request go list -m all alongside go env in the issue template.

(CC @thepudds @myitcv @bradfitz)

@bcmills bcmills added Proposal NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Feb 15, 2019
@bcmills bcmills added this to the Unreleased milestone Feb 15, 2019
@thepudds
Copy link
Contributor

This is probably good to do independent of the outcome of #30241.

Some people will want to remove proprietary or internal modules from the output of go list -m all, or substitute in foo or corp.example or similar. The template could attempt to briefly mention that is fine to do. Alternatively, could instead just wait to see if it confuses anyone in practice.

If you are not running with module mode enabled, go list -m all currently reports:

go list -m: not using modules

That is probably fine and understandable enough to not confuse people.

@ianlancetaylor ianlancetaylor added this to Incoming in Proposals (old) Feb 24, 2021
@rsc
Copy link
Contributor

rsc commented Jun 22, 2022

Removing from proposal process. Release team can decide on their own here; it's easy enough to change if we get it wrong.

@rsc rsc removed this from Incoming in Proposals (old) Jun 22, 2022
@rsc rsc removed the Proposal label Jun 22, 2022
@dmitshur
Copy link
Contributor

This seems reasonable, @bcmills want to send a CL for this? We can try it and adjust based on experience.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. Community and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Jun 28, 2022
@dmitshur dmitshur added this to Planned in Go Release Team Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community NeedsFix The path to resolution is known, but the work has not been done.
Projects
Status: Planned
Development

No branches or pull requests

4 participants