Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/textproto: prevent test from failing with nil pointer dereference #30214

Closed
wants to merge 1 commit into from
Closed

net/textproto: prevent test from failing with nil pointer dereference #30214

wants to merge 1 commit into from

Conversation

marat-rkh
Copy link

The variable err could have nil value when we call err.Error(),
because after we check it for nil above we continue the test
(t.Errorf doesn't stop the test execution).

Updates #30208

@marat-rkh
net/textproto: prevent test from failing with nil pointer dereference
3ab20f6 
The variable err could have nil value when we call err.Error(),
because after we check it for nil above we continue the test
(t.Errorf doesn't stop the test execution).

Updates golang#30208
@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Feb 13, 2019
@gopherbot
Copy link

This PR (HEAD: 3ab20f6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/162457 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 1: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/162457.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=d7b17b29

Please don’t reply on this GitHub thread. Visit golang.org/cl/162457.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/162457.
After addressing review feedback, remember to publish your drafts!

@marat-rkh
Copy link
Author

I opened a new pull request that contains changes from this one.
#30226
Current request can be closed (rejected). Doing this as requested here:
#30208 (comment)

@marat-rkh marat-rkh closed this Feb 14, 2019
gopherbot pushed a commit that referenced this pull request Feb 26, 2019
@marat-rkh @mvdan
net/textproto: prevent test from failing with nil pointer dereference
c6e4706 
The variable err could have nil value when we call err.Error(),
because after we check it for nil above we continue the test
(t.Errorf doesn't stop the test execution).

Updates #30208

Change-Id: Ibcf38698326c69c06068989510311e37806995c6
GitHub-Last-Rev: 3ab20f6
GitHub-Pull-Request: #30214
Reviewed-on: https://go-review.googlesource.com/c/162457
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marat-rkh @gopherbot @googlebot