Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc/install.html: inconsistent slash in Windows directory name #30160

Closed
nobozo opened this issue Feb 10, 2019 · 7 comments
Closed

doc/install.html: inconsistent slash in Windows directory name #30160

nobozo opened this issue Feb 10, 2019 · 7 comments
Labels
Documentation FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.13

Comments

@nobozo
Copy link

nobozo commented Feb 10, 2019

This is a minor documentation bug report for what appears on

https://golang.org/doc/install?download=go1.11.5.windows-amd64.msi#install

It says

"Next, make the directory src/hello inside your workspace"

It should be

"Next, make the directory src\hello inside your workspace"

The rest of this page uses backslash characters when showing Windows pathnames, so this sentence should also.
@bcmills bcmills changed the title Inconsistent Use of Slash in Windows Directory Name in Documentation doc/install.html: inconsistent slash in Windows directory name Feb 12, 2019
@bcmills bcmills added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Feb 12, 2019
@bcmills
Copy link
Contributor

bcmills commented Feb 12, 2019 •
edited

The fix goes here. Want to send a change?

(https://golang.org/doc/contribute.html has instructions.)

@bcmills bcmills added this to the Go1.13 milestone Feb 12, 2019
@cbynon
Copy link
Contributor

cbynon commented Feb 12, 2019

Can I take this one? I have never submitted a fix before and have been looking for one for ages that is simple so that I can learn the process more so than the actual fix. Thanks.

@bcmills
Copy link
Contributor

bcmills commented Feb 12, 2019

Go for it.

Note that we're currently still in the release freeze for Go 1.12, so it might be a week or two before we can merge the fix.

@cbynon
Copy link
Contributor

cbynon commented Feb 12, 2019

No problem, thanks.

@andriisoldatenko
Copy link
Contributor

@cbynon are you still going to make a fix?

@cbynon
Copy link
Contributor

cbynon commented Feb 15, 2019

Yes, definitely. I'll have it done over the weekend. As this is my first time submitting a fix on github I'm just going through the contribution notes and making sure I'm doing it correctly. Let me know if this is a problem, thanks.

@gopherbot
Copy link

Change https://golang.org/cl/162918 mentions this issue: doc: fixed incorrect slash in windows path

@golang golang locked and limited conversation to collaborators Mar 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
5 participants
@andriisoldatenko @nobozo @bcmills @gopherbot @cbynon