Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev.boringcrypto: update BoringCrypto module #30158

Closed
akashgiri opened this issue Feb 10, 2019 · 10 comments
Closed

dev.boringcrypto: update BoringCrypto module #30158

akashgiri opened this issue Feb 10, 2019 · 10 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@akashgiri
Copy link

akashgiri commented Feb 10, 2019

We are exploring the usage of dev.boringcrypto branches for our compliance needs. The current dev.boringcrypto branches refer the older security policy, sp2964.
What are the plans to update the dev.boringcrypto branches to updated security policies (sp3318 is current)?

Older security policy: https://csrc.nist.gov/csrc/media/projects/cryptographic-module-validation-program/documents/security-policies/140sp2964.pdf
Current security policy: https://csrc.nist.gov/csrc/media/projects/cryptographic-module-validation-program/documents/security-policies/140sp3318.pdf

@FiloSottile
Copy link
Contributor

/cc @agl

@bcmills
Copy link
Contributor

bcmills commented Feb 28, 2019

CC @rsc

@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 28, 2019
@andybons andybons changed the title crypto: Updates in dev.boringcrypto branches as per updated security policies proposal: crypto: update dev.boringcrypto branches as per security policies Aug 12, 2019
@andybons andybons added Proposal-Crypto Proposal related to crypto packages or other security issues and removed Proposal Question labels Aug 12, 2019
@FiloSottile
Copy link
Contributor

@agl Can we / should we update the reference to 140sp3318.pdf? AFAIK we have not updated the BoringCrypto module itself. (Should we do that when a new validation comes through?)

@FiloSottile FiloSottile changed the title proposal: crypto: update dev.boringcrypto branches as per security policies dev.boringcrypto: update security policy reference Feb 5, 2020
@FiloSottile FiloSottile added NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Proposal Proposal-Crypto Proposal related to crypto packages or other security issues labels Feb 5, 2020
@agl
Copy link
Contributor

agl commented Feb 5, 2020

we have not updated the BoringCrypto module itself. (Should we do that when a new validation comes through?)

Ideally, yes.

Can we / should we update the reference to 140sp3318.pdf?

The reference should match the BoringCrypto module in use.

@FiloSottile FiloSottile changed the title dev.boringcrypto: update security policy reference dev.boringcrypto: update BoringCrypto module Feb 5, 2020
@FiloSottile FiloSottile added NeedsFix The path to resolution is known, but the work has not been done. and removed ExpertNeeded NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Feb 5, 2020
@FiloSottile FiloSottile self-assigned this Feb 5, 2020
@FiloSottile FiloSottile modified the milestones: Unreleased, Go1.14 Feb 5, 2020
@FiloSottile
Copy link
Contributor

I'll give this a shot for Go 1.14 then.

@gopherbot
Copy link

Change https://golang.org/cl/218000 mentions this issue: [dev.boringcrypto] crypto/internal/boring: update BoringCrypto module to certificate 3318

@toothrot toothrot modified the milestones: Go1.14, Go1.15 Feb 25, 2020
gopherbot pushed a commit that referenced this issue Mar 2, 2020
… to certificate 3318

Use OPENSSL_malloc for set0 functions as OPENSSL_free now catches us
using the libc malloc and aborts.

While at it, move the runtime.KeepAlive to the location of the key use.

Fixes #30158

Change-Id: I968a98d8974ca5f220e822841beb6c34290eefe9
Reviewed-on: https://go-review.googlesource.com/c/go/+/218000
Reviewed-by: Katie Hockman <katie@golang.org>
@dorsha
Copy link

dorsha commented Mar 27, 2020

Hi @FiloSottile, I see that the new BoringCrypto security policy version sp3318 is planned to be part of Golang 1.15.

Did you replace the implementation of boringcrypto:SP 800-135 KDF and KAS ECC to use BoringCrypto? We are under going FIPS certification process and we got a request to make them FIPS complaint as well.

Thanks!

@FiloSottile
Copy link
Contributor

The new BoringCrypto object has landed in dev.boringcrypto.

@dorsha I'm not sure I understand the question, could you elaborate in a new issue or by email? I'm filippo at golang.

@agl
Copy link
Contributor

agl commented Apr 21, 2020

Did you replace the implementation of boringcrypto:SP 800-135 KDF and KAS ECC to use BoringCrypto? We are under going FIPS certification process and we got a request to make them FIPS complaint as well.

(I think this is requesting extra patching out from crypto/tls. NIST has weird names for things, but I suspect that the functions in question are probably CRYPTO_tls1_prf and ECDH_compute_key_fips.)

@FiloSottile
Copy link
Contributor

Thanks @agl! @dorsha if that's accurate it's probably something we can look at, please open a new issue with as much detail about the requirement as possible.

@golang golang locked and limited conversation to collaborators Apr 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

9 participants