Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/packages: set TypeSizes without type-checking package #30139

Closed
stamblerre opened this issue Feb 8, 2019 · 1 comment
Closed

x/tools/go/packages: set TypeSizes without type-checking package #30139

stamblerre opened this issue Feb 8, 2019 · 1 comment
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@stamblerre
Copy link
Contributor

packages.Load with mode LoadImports or below does not set the TypeSizes field on the returned packages, even though that information is readily available.

Context: https://go-review.googlesource.com/c/tools/+/161670
@gopherbot gopherbot added this to the Unreleased milestone Feb 8, 2019
@matloob
Copy link
Contributor

matloob commented Mar 27, 2019

Now you can pass in the bits! NeedTypesSizes will fill in the TypesSizes field

@matloob matloob closed this as completed Mar 27, 2019
@golang golang locked and limited conversation to collaborators Mar 26, 2020
@rsc rsc unassigned matloob Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@stamblerre @gopherbot @matloob