You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The official Windows msi installer sets GOROOT, this is mostly harmless however causes a problem when dealing with multiple Go versions and may lead to unexpected behavior as the user may not be aware that GOROOT is set and is assuming will be inferred.
The official install docs haven't recommended setting GOROOT since 1.10; the last remaining bit was https://go-review.googlesource.com/c/go/+/161758, which hopefully will be removed in the 1.12 release.
So unless there's a good reason to set GOROOT on Windows, I think the installer should follow the same rule.
@andybons CL 163299 LGTM assuming what Daniel said. But I do not know how to test the CL. I, probably, need some tools to build installer. How do I test the CL?
The official Windows msi installer sets GOROOT, this is mostly harmless however causes a problem when dealing with multiple Go versions and may lead to unexpected behavior as the user may not be aware that GOROOT is set and is assuming will be inferred.
This has lead to reports like #30126 (mine)
The text was updated successfully, but these errors were encountered: